From: James Morse <james.morse@arm.com>
To: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
kexec@lists.infradead.org, Will Deacon <will.deacon@arm.com>,
Rob Herring <robh+dt@kernel.org>,
AKASHI Takahiro <takahiro.akashi@linaro.org>,
Catalin Marinas <catalin.marinas@arm.com>,
David Howells <dhowells@redhat.com>,
Vivek Goyal <vgoyal@redhat.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
David Miller <davem@davemloft.net>,
dyoung@redhat.com, Baoquan He <bhe@redhat.com>,
Arnd Bergmann <arnd@arndb.de>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
prudo@linux.ibm.com, Ard Biesheuvel <ard.biesheuvel@linaro.org>,
bhsharma@redhat.com, Frank Rowand <frowand.list@gmail.com>,
James Morse <james.morse@arm.com>
Subject: [PATCH arm64/kexec] arm64: kexec_file: forbid kdump via kexec_file_load()
Date: Fri, 7 Dec 2018 10:14:39 +0000 [thread overview]
Message-ID: <20181207101439.190918-1-james.morse@arm.com> (raw)
Now that kexec_walk_memblock() can do the crash-kernel placement itself
architectures that don't support kdump via kexe_file_load() need to
explicitly forbid it.
We don't support this on arm64 until the kernel can add the elfcorehdr
and usable-memory-range fields to the DT. Without these the crash-kernel
overwrites the previous kernel's memory during startup.
Add a check to refuse crash image loading.
Signed-off-by: James Morse <james.morse@arm.com>
---
Context: http://lore.kernel.org/r/20181206155424.GA4422@arm.com
arch/arm64/kernel/kexec_image.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm64/kernel/kexec_image.c b/arch/arm64/kernel/kexec_image.c
index 1ad1d5f8f024..07bf740bea91 100644
--- a/arch/arm64/kernel/kexec_image.c
+++ b/arch/arm64/kernel/kexec_image.c
@@ -47,6 +47,10 @@ static void *image_load(struct kimage *image,
struct kexec_segment *kernel_segment;
int ret;
+ /* We don't support crash kernels yet. */
+ if (image->type == KEXEC_TYPE_CRASH)
+ return ERR_PTR(-EOPNOTSUPP);
+
/*
* We require a kernel with an unambiguous Image header. Per
* Documentation/booting.txt, this is the case when image_size
--
2.19.2
next reply other threads:[~2018-12-07 10:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-07 10:14 James Morse [this message]
2018-12-07 15:26 ` [PATCH arm64/kexec] arm64: kexec_file: forbid kdump via kexec_file_load() Bhupesh Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181207101439.190918-1-james.morse@arm.com \
--to=james.morse@arm.com \
--cc=ard.biesheuvel@linaro.org \
--cc=arnd@arndb.de \
--cc=bhe@redhat.com \
--cc=bhsharma@redhat.com \
--cc=catalin.marinas@arm.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dhowells@redhat.com \
--cc=dyoung@redhat.com \
--cc=frowand.list@gmail.com \
--cc=heiko.carstens@de.ibm.com \
--cc=herbert@gondor.apana.org.au \
--cc=kexec@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=prudo@linux.ibm.com \
--cc=robh+dt@kernel.org \
--cc=schwidefsky@de.ibm.com \
--cc=takahiro.akashi@linaro.org \
--cc=vgoyal@redhat.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).