From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Pavel Machek <pavel@ucw.cz>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Baolin Wang <baolin.wang@linaro.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Raphael Teysseyre <rteysseyre@gmail.com>,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 4/4] leds: trigger: Add pattern initialization from Device Tree
Date: Fri, 7 Dec 2018 13:32:54 +0100 [thread overview]
Message-ID: <1544185974-5932-4-git-send-email-krzk@kernel.org> (raw)
In-Reply-To: <1544185974-5932-1-git-send-email-krzk@kernel.org>
Allow initialization of pattern used in pattern trigger from Device Tree
property.
This is especially useful for embedded systems where the pattern trigger
would be used to indicate the process of boot status in a nice,
user-friendly blinking way. This initialization pattern will be used
till user-space is brought up and sets its own pattern, indicating the
boot status is for example finished.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/leds/trigger/ledtrig-pattern.c | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/drivers/leds/trigger/ledtrig-pattern.c b/drivers/leds/trigger/ledtrig-pattern.c
index 1870cf87afe1..96309d3bc43c 100644
--- a/drivers/leds/trigger/ledtrig-pattern.c
+++ b/drivers/leds/trigger/ledtrig-pattern.c
@@ -11,6 +11,7 @@
#include <linux/leds.h>
#include <linux/module.h>
#include <linux/mutex.h>
+#include <linux/of.h>
#include <linux/slab.h>
#include <linux/timer.h>
@@ -331,6 +332,21 @@ static const struct attribute_group *pattern_trig_groups[] = {
NULL,
};
+static void pattern_init(struct led_classdev *led_cdev)
+{
+ struct device_node *np = dev_of_node(led_cdev->dev);
+ const char *pattern;
+
+ if (!np)
+ return;
+
+ if (!of_property_read_string(np, "linux,trigger-pattern", &pattern)) {
+ if (strlen(pattern))
+ pattern_trig_store_patterns(led_cdev, pattern,
+ strlen(pattern), false);
+ }
+}
+
static int pattern_trig_activate(struct led_classdev *led_cdev)
{
struct pattern_trig_data *data;
@@ -354,6 +370,8 @@ static int pattern_trig_activate(struct led_classdev *led_cdev)
timer_setup(&data->timer, pattern_trig_timer_function, 0);
led_cdev->activated = true;
+ pattern_init(led_cdev);
+
return 0;
}
--
2.7.4
next prev parent reply other threads:[~2018-12-07 12:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-07 12:32 [PATCH 1/4] leds: pwm: Simplify with resource-managed devm_led_classdev_register() Krzysztof Kozlowski
2018-12-07 12:32 ` [PATCH 2/4] leds: pwm: Use OF variant of LED registering function Krzysztof Kozlowski
2018-12-07 12:32 ` [PATCH 3/4] dt-bindings: leds: Add pattern initialization from Device Tree Krzysztof Kozlowski
2018-12-07 12:32 ` Krzysztof Kozlowski [this message]
2018-12-08 18:44 ` [PATCH 4/4] leds: trigger: " Jacek Anaszewski
2018-12-09 18:55 ` Jacek Anaszewski
2018-12-10 8:35 ` Krzysztof Kozlowski
2018-12-09 8:17 ` Pavel Machek
2018-12-10 8:34 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1544185974-5932-4-git-send-email-krzk@kernel.org \
--to=krzk@kernel.org \
--cc=baolin.wang@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=rteysseyre@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).