[4/5] char: lp: properly count the lp devices
diff mbox series

Message ID 20181207142734.27370-4-sudipm.mukherjee@gmail.com
State Accepted
Commit e379c1a46068969a2b822a15dbc9a37577e1e04f
Headers show
  • [1/5] char: lp: introduce list to save port number
Related show

Commit Message

Sudip Mukherjee Dec. 7, 2018, 2:27 p.m. UTC
When the parallel port is usb based and the lp attaches to it based on
LP_PARPORT_AUTO, we do get /dev/lp0 and when we remove the usb device
/dev/lp0 is unregistered. If we now reconnect the usb device we get
our /dev/lp0 back. But if we now disconnect and reconnect eight times
we donot get any lp device and dmesg shows:

    lp: ignoring parallel port (max. 8)

Decrement the lp_count when the device detaches as this represents the
number of lp devices connected to the system.

Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
 drivers/char/lp.c | 1 +
 1 file changed, 1 insertion(+)

diff mbox series

diff --git a/drivers/char/lp.c b/drivers/char/lp.c
index 0e081f521f51..cef2ea386f5e 100644
--- a/drivers/char/lp.c
+++ b/drivers/char/lp.c
@@ -993,6 +993,7 @@  static void lp_detach(struct parport *port)
 	for (n = 0; n < LP_NO; n++) {
 		if (port_num[n] == port->number) {
 			port_num[n] = -1;
+			lp_count--;
 			device_destroy(lp_class, MKDEV(LP_MAJOR, n));