From: Kyle Williams <kdgwill@chromium.org>
To: linux-kernel@vger.kernel.org
Cc: kdgwill@chromium.org,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Alan Stern" <stern@rowland.harvard.edu>,
"Mathias Nyman" <mathias.nyman@linux.intel.com>,
"Nicolas Boichat" <drinkcat@chromium.org>,
"Jon Flatley" <jflat@chromium.org>,
"Felipe Balbi" <felipe.balbi@linux.intel.com>,
"Kai-Heng Feng" <kai.heng.feng@canonical.com>,
"Danilo Krummrich" <danilokrummrich@dk-develop.de>,
"Kuppuswamy Sathyanarayanan"
<sathyanarayanan.kuppuswamy@linux.intel.com>,
"Maxence Duprès" <xpros64@hotmail.fr>,
"Kamil Lulko" <kamilx.lulko@intel.com>,
"Emmanuel Pescosta" <emmanuelpescosta099@gmail.com>,
linux-usb@vger.kernel.org
Subject: [PATCH v2] USB: quirks: disable LPM for Logitech UVC devices
Date: Fri, 7 Dec 2018 19:46:38 -0500 [thread overview]
Message-ID: <20181208004641.240699-1-kdgwill@google.com> (raw)
In-Reply-To: <20181207222138.GB161210@google.com>
From: Kyle Williams <kdgwill@chromium.org>
Description: Some USB device / host controller combinations seem to have
problems with Link Power management. In particular it is described that
the combination of certain Logitech uvc devices and other powered media
devices such causes 'not enough bandwidth for new device state' error.
This patch enables the USB_QUIRK_NO_LPM quirk entries for all connected
Logitech UVC devices indicating LPM should remain disabled for the device.
Signed-off-by: Kyle Williams <kdgwill@chromium.org>
---
Changes in v2:
- changed commit message
- disble lpm for all logitech uvc devices instead of listing manually
- changes to allow the lpm to correctly be disabled after enumeration
drivers/usb/core/hub.c | 87 +++++++++++++++++++++------------------
drivers/usb/core/quirks.c | 2 +-
2 files changed, 49 insertions(+), 40 deletions(-)
diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
index 0f9381b69a3b..8f366ec4d21b 100644
--- a/drivers/usb/core/hub.c
+++ b/drivers/usb/core/hub.c
@@ -365,6 +365,51 @@ static void usb_set_lpm_parameters(struct usb_device *udev)
usb_set_lpm_sel(udev, &udev->u2_params);
}
+/*
+ * There are reports of USB 3.0 devices that say they support USB 2.0 Link PM
+ * when they're plugged into a USB 2.0 port, but they don't work when LPM is
+ * enabled.
+ *
+ * Only enable USB 2.0 Link PM if the port is internal (hardwired), or the
+ * device says it supports the new USB 2.0 Link PM errata by setting the BESL
+ * support bit in the BOS descriptor.
+ */
+static void hub_set_initial_usb2_lpm_policy(struct usb_device *udev)
+{
+ struct usb_hub *hub = usb_hub_to_struct_hub(udev->parent);
+ int connect_type = USB_PORT_CONNECT_TYPE_UNKNOWN;
+
+ if (!udev->usb2_hw_lpm_capable || !udev->bos)
+ return;
+
+ if (hub)
+ connect_type = hub->ports[udev->portnum - 1]->connect_type;
+
+ if ((udev->bos->ext_cap->bmAttributes & cpu_to_le32(USB_BESL_SUPPORT))
+ || connect_type == USB_PORT_CONNECT_TYPE_HARD_WIRED) {
+ udev->usb2_hw_lpm_allowed = 1;
+ usb_set_usb2_hardware_lpm(udev, 1);
+ }
+}
+
+void usb_update_device_lpm(struct usb_hcd *hcd, struct usb_device *udev)
+{
+ int retval;
+
+ if (udev->wusb == 0 && le16_to_cpu(udev->descriptor.bcdUSB) >= 0x0201) {
+ retval = usb_get_bos_descriptor(udev);
+ if (!retval) {
+ udev->lpm_capable = usb_device_supports_lpm(udev);
+ usb_set_lpm_parameters(udev);
+ }
+ }
+
+ /* notify HCD that we have a device connected and addressed */
+ if (hcd->driver->update_device)
+ hcd->driver->update_device(hcd, udev);
+ hub_set_initial_usb2_lpm_policy(udev);
+}
+
/* USB 2.0 spec Section 11.24.4.5 */
static int get_hub_descriptor(struct usb_device *hdev,
struct usb_hub_descriptor *desc)
@@ -2295,7 +2340,6 @@ static int usb_enumerate_device_otg(struct usb_device *udev)
return err;
}
-
/**
* usb_enumerate_device - Read device configs/intfs/otg (usbcore-internal)
* @udev: newly addressed device (in ADDRESS state)
@@ -2351,6 +2395,8 @@ static int usb_enumerate_device(struct usb_device *udev)
usb_detect_interface_quirks(udev);
+ usb_update_device_lpm(hcd, udev);
+
return 0;
}
@@ -4402,33 +4448,6 @@ static int hub_set_address(struct usb_device *udev, int devnum)
return retval;
}
-/*
- * There are reports of USB 3.0 devices that say they support USB 2.0 Link PM
- * when they're plugged into a USB 2.0 port, but they don't work when LPM is
- * enabled.
- *
- * Only enable USB 2.0 Link PM if the port is internal (hardwired), or the
- * device says it supports the new USB 2.0 Link PM errata by setting the BESL
- * support bit in the BOS descriptor.
- */
-static void hub_set_initial_usb2_lpm_policy(struct usb_device *udev)
-{
- struct usb_hub *hub = usb_hub_to_struct_hub(udev->parent);
- int connect_type = USB_PORT_CONNECT_TYPE_UNKNOWN;
-
- if (!udev->usb2_hw_lpm_capable || !udev->bos)
- return;
-
- if (hub)
- connect_type = hub->ports[udev->portnum - 1]->connect_type;
-
- if ((udev->bos->ext_cap->bmAttributes & cpu_to_le32(USB_BESL_SUPPORT)) ||
- connect_type == USB_PORT_CONNECT_TYPE_HARD_WIRED) {
- udev->usb2_hw_lpm_allowed = 1;
- usb_set_usb2_hardware_lpm(udev, 1);
- }
-}
-
static int hub_enable_device(struct usb_device *udev)
{
struct usb_hcd *hcd = bus_to_hcd(udev->bus);
@@ -4779,19 +4798,9 @@ hub_port_init(struct usb_hub *hub, struct usb_device *udev, int port1,
usb_detect_quirks(udev);
- if (udev->wusb == 0 && le16_to_cpu(udev->descriptor.bcdUSB) >= 0x0201) {
- retval = usb_get_bos_descriptor(udev);
- if (!retval) {
- udev->lpm_capable = usb_device_supports_lpm(udev);
- usb_set_lpm_parameters(udev);
- }
- }
+ usb_update_device_lpm(hcd, udev);
retval = 0;
- /* notify HCD that we have a device connected and addressed */
- if (hcd->driver->update_device)
- hcd->driver->update_device(hcd, udev);
- hub_set_initial_usb2_lpm_policy(udev);
fail:
if (retval) {
hub_port_disable(hub, port1, 0);
diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
index 0690fcff0ea2..bbbb7e6df958 100644
--- a/drivers/usb/core/quirks.c
+++ b/drivers/usb/core/quirks.c
@@ -440,7 +440,7 @@ static const struct usb_device_id usb_quirk_list[] = {
static const struct usb_device_id usb_interface_quirk_list[] = {
/* Logitech UVC Cameras */
{ USB_VENDOR_AND_INTERFACE_INFO(0x046d, USB_CLASS_VIDEO, 1, 0),
- .driver_info = USB_QUIRK_RESET_RESUME },
+ .driver_info = USB_QUIRK_RESET_RESUME | USB_QUIRK_NO_LPM },
{ } /* terminating entry must be last */
};
--
2.20.0.rc2.403.gdbc3b29805-goog
next prev parent reply other threads:[~2018-12-08 0:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAAd214WBzcsFamzqkdTp0AYDRo1=Uq1=Z5fJhzkOZ6znVFo3MA@mail.gmail.com>
2018-12-04 21:36 ` [PATCH] USB: quirks: add NO_LPM quirk for Logitech Flare|Meetup|Brio|Rally Alan Stern
2018-12-07 22:18 ` Kyle Williams
2018-12-10 13:50 ` Mathias Nyman
2019-01-10 14:36 ` Kyle Williams
2018-12-05 9:39 ` Greg Kroah-Hartman
2018-12-07 22:21 ` Kyle Williams
2018-12-08 0:46 ` Kyle Williams [this message]
2018-12-08 1:47 ` [PATCH v3 0/2] Disable LPM by matching interface Kyle Williams
2018-12-08 1:47 ` [PATCH v3 1/2] USB: quirks: Check device interface LPM capability Kyle Williams
2018-12-12 11:37 ` Greg Kroah-Hartman
2019-01-10 15:49 ` Kyle Williams
2019-01-11 9:09 ` Greg Kroah-Hartman
2018-12-08 1:47 ` [PATCH v3 2/2] USB: quirks: Disable LPM for Logitech UVC devices Kyle Williams
2018-12-12 11:37 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181208004641.240699-1-kdgwill@google.com \
--to=kdgwill@chromium.org \
--cc=danilokrummrich@dk-develop.de \
--cc=drinkcat@chromium.org \
--cc=emmanuelpescosta099@gmail.com \
--cc=felipe.balbi@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jflat@chromium.org \
--cc=kai.heng.feng@canonical.com \
--cc=kamilx.lulko@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@linux.intel.com \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=stern@rowland.harvard.edu \
--cc=xpros64@hotmail.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).