From: Kyle Williams <kdgwill@chromium.org>
To: linux-kernel@vger.kernel.org
Cc: kdgwill@chromium.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alan Stern <stern@rowland.harvard.edu>,
Mathias Nyman <mathias.nyman@linux.intel.com>,
Nicolas Boichat <drinkcat@chromium.org>,
Jon Flatley <jflat@chromium.org>,
Felipe Balbi <felipe.balbi@linux.intel.com>,
Kai-Heng Feng <kai.heng.feng@canonical.com>,
Kuppuswamy Sathyanarayanan
<sathyanarayanan.kuppuswamy@linux.intel.com>,
Harry Pan <harry.pan@intel.com>,
Emmanuel Pescosta <emmanuelpescosta099@gmail.com>,
Danilo Krummrich <danilokrummrich@dk-develop.de>,
Dmitry Fleytman Dmitry Fleytman <dmitry.fleytman@gmail.com>,
linux-usb@vger.kernel.org
Subject: [PATCH v3 2/2] USB: quirks: Disable LPM for Logitech UVC devices
Date: Fri, 7 Dec 2018 20:47:22 -0500 [thread overview]
Message-ID: <20181208014724.951-3-kdgwill@google.com> (raw)
In-Reply-To: <20181208014724.951-1-kdgwill@google.com>
From: Kyle Williams <kdgwill@chromium.org>
Description: Some USB device / host controller combinations seem to have
problems with Link Power management. In particular it is described that
the combination of certain Logitech uvc devices and other powered media
devices such causes 'not enough bandwidth for new device state' error.
This patch enables the USB_QUIRK_NO_LPM quirk entries for all connected
Logitech UVC devices indicating LPM should remain disabled for the device.
Signed-off-by: Kyle Williams <kdgwill@chromium.org>
---
drivers/usb/core/quirks.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
index 0690fcff0ea2..bbbb7e6df958 100644
--- a/drivers/usb/core/quirks.c
+++ b/drivers/usb/core/quirks.c
@@ -440,7 +440,7 @@ static const struct usb_device_id usb_quirk_list[] = {
static const struct usb_device_id usb_interface_quirk_list[] = {
/* Logitech UVC Cameras */
{ USB_VENDOR_AND_INTERFACE_INFO(0x046d, USB_CLASS_VIDEO, 1, 0),
- .driver_info = USB_QUIRK_RESET_RESUME },
+ .driver_info = USB_QUIRK_RESET_RESUME | USB_QUIRK_NO_LPM },
{ } /* terminating entry must be last */
};
--
2.20.0.rc2.403.gdbc3b29805-goog
next prev parent reply other threads:[~2018-12-08 1:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAAd214WBzcsFamzqkdTp0AYDRo1=Uq1=Z5fJhzkOZ6znVFo3MA@mail.gmail.com>
2018-12-04 21:36 ` [PATCH] USB: quirks: add NO_LPM quirk for Logitech Flare|Meetup|Brio|Rally Alan Stern
2018-12-07 22:18 ` Kyle Williams
2018-12-10 13:50 ` Mathias Nyman
2019-01-10 14:36 ` Kyle Williams
2018-12-05 9:39 ` Greg Kroah-Hartman
2018-12-07 22:21 ` Kyle Williams
2018-12-08 0:46 ` [PATCH v2] USB: quirks: disable LPM for Logitech UVC devices Kyle Williams
2018-12-08 1:47 ` [PATCH v3 0/2] Disable LPM by matching interface Kyle Williams
2018-12-08 1:47 ` [PATCH v3 1/2] USB: quirks: Check device interface LPM capability Kyle Williams
2018-12-12 11:37 ` Greg Kroah-Hartman
2019-01-10 15:49 ` Kyle Williams
2019-01-11 9:09 ` Greg Kroah-Hartman
2018-12-08 1:47 ` Kyle Williams [this message]
2018-12-12 11:37 ` [PATCH v3 2/2] USB: quirks: Disable LPM for Logitech UVC devices Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181208014724.951-3-kdgwill@google.com \
--to=kdgwill@chromium.org \
--cc=danilokrummrich@dk-develop.de \
--cc=dmitry.fleytman@gmail.com \
--cc=drinkcat@chromium.org \
--cc=emmanuelpescosta099@gmail.com \
--cc=felipe.balbi@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=harry.pan@intel.com \
--cc=jflat@chromium.org \
--cc=kai.heng.feng@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@linux.intel.com \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).