From: tip-bot for Borislav Petkov <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: mingo@kernel.org, bp@suse.de, hpa@zytor.com,
linux-kernel@vger.kernel.org, mhiramat@kernel.org,
tglx@linutronix.de
Subject: [tip:x86/cleanups] x86/kprobes: Remove trampoline_handler() prototype
Date: Sat, 8 Dec 2018 03:31:30 -0800 [thread overview]
Message-ID: <tip-4b1bacab61aa252d15dde99cd0440a965bd863e5@git.kernel.org> (raw)
In-Reply-To: <20181205162526.GB109259@gmail.com>
Commit-ID: 4b1bacab61aa252d15dde99cd0440a965bd863e5
Gitweb: https://git.kernel.org/tip/4b1bacab61aa252d15dde99cd0440a965bd863e5
Author: Borislav Petkov <bp@suse.de>
AuthorDate: Fri, 7 Dec 2018 20:38:09 +0100
Committer: Borislav Petkov <bp@suse.de>
CommitDate: Sat, 8 Dec 2018 12:25:12 +0100
x86/kprobes: Remove trampoline_handler() prototype
... and make it static. It is called only by the kretprobe_trampoline()
from asm.
It was marked __visible so that it is visible outside of the current
compilation unit but that is not needed as it is used only in this
compilation unit.
Signed-off-by: Borislav Petkov <bp@suse.de>
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Link: https://lkml.kernel.org/r/20181205162526.GB109259@gmail.com
---
arch/x86/kernel/kprobes/core.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/arch/x86/kernel/kprobes/core.c b/arch/x86/kernel/kprobes/core.c
index 6480056d370f..308bf103cc73 100644
--- a/arch/x86/kernel/kprobes/core.c
+++ b/arch/x86/kernel/kprobes/core.c
@@ -66,8 +66,6 @@
#include "common.h"
-void *trampoline_handler(struct pt_regs *regs);
-
DEFINE_PER_CPU(struct kprobe *, current_kprobe) = NULL;
DEFINE_PER_CPU(struct kprobe_ctlblk, kprobe_ctlblk);
@@ -753,7 +751,7 @@ STACK_FRAME_NON_STANDARD(kretprobe_trampoline);
/*
* Called from kretprobe_trampoline
*/
-__visible __used void *trampoline_handler(struct pt_regs *regs)
+static __used void *trampoline_handler(struct pt_regs *regs)
{
struct kretprobe_instance *ri = NULL;
struct hlist_head *head, empty_rp;
next prev parent reply other threads:[~2018-12-08 11:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-05 10:11 [PATCH] x86/kernel: Fix more -Wmissing-prototypes warnings Borislav Petkov
2018-12-05 12:44 ` Rafael J. Wysocki
2018-12-05 13:49 ` Masami Hiramatsu
2018-12-05 14:24 ` Borislav Petkov
2018-12-05 16:25 ` Ingo Molnar
2018-12-05 17:15 ` Borislav Petkov
2018-12-07 14:42 ` Masami Hiramatsu
2018-12-07 19:48 ` Borislav Petkov
2018-12-08 5:56 ` Masami Hiramatsu
2018-12-08 11:31 ` tip-bot for Borislav Petkov [this message]
2018-12-07 15:21 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-4b1bacab61aa252d15dde99cd0440a965bd863e5@git.kernel.org \
--to=tipbot@zytor.com \
--cc=bp@suse.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).