| Message ID | 20181208175847.32068-3-oskari@lemmela.net |
|---|---|
| State | Accepted |
| Commit | ea90e7b47f0a8bd2fe14e9a88f523de7c67db90a |
| Headers | show |
| Series |
|
| Related | show |
On Sat, 08 Dec 2018, Oskari Lemmela wrote: > Parts of the AXP803 are compatible with their counterparts on the AXP813. > These include the GPIO, ADC, AC and battery power supplies. > > Signed-off-by: Oskari Lemmela <oskari@lemmela.net> > Reviewed-by: Chen-Yu Tsai <wens@csie.org> > Tested-by: Vasily Khoruzhick <anarsoul@gmail.com> > Signed-off-by: Chen-Yu Tsai <wens@csie.org> > --- > drivers/mfd/axp20x.c | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) Applied, thanks.
On Sat, 08 Dec 2018, Oskari Lemmela wrote: > Parts of the AXP803 are compatible with their counterparts on the AXP813. > These include the GPIO, ADC, AC and battery power supplies. > > Signed-off-by: Oskari Lemmela <oskari@lemmela.net> > Reviewed-by: Chen-Yu Tsai <wens@csie.org> > Tested-by: Vasily Khoruzhick <anarsoul@gmail.com> > Signed-off-by: Chen-Yu Tsai <wens@csie.org> I'm happy to fix this, but ... Can you explain these tags for me please? Specifically the last one. Why does Chen-Yu Tsai have an SoB there? > --- > drivers/mfd/axp20x.c | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c > index 8037b4e01ed6..f8e0fa97bb31 100644 > --- a/drivers/mfd/axp20x.c > +++ b/drivers/mfd/axp20x.c > @@ -726,6 +726,20 @@ static const struct mfd_cell axp803_cells[] = { > .name = "axp221-pek", > .num_resources = ARRAY_SIZE(axp803_pek_resources), > .resources = axp803_pek_resources, > + }, { > + .name = "axp20x-gpio", > + .of_compatible = "x-powers,axp813-gpio", > + }, { > + .name = "axp813-adc", > + .of_compatible = "x-powers,axp813-adc", > + }, { > + .name = "axp20x-battery-power-supply", > + .of_compatible = "x-powers,axp813-battery-power-supply", > + }, { > + .name = "axp20x-ac-power-supply", > + .of_compatible = "x-powers,axp813-ac-power-supply", > + .num_resources = ARRAY_SIZE(axp20x_ac_power_supply_resources), > + .resources = axp20x_ac_power_supply_resources, > }, > { .name = "axp20x-regulator" }, > };
On Mon, Dec 10, 2018 at 2:35 PM Lee Jones <lee.jones@linaro.org> wrote: > > On Sat, 08 Dec 2018, Oskari Lemmela wrote: > > > Parts of the AXP803 are compatible with their counterparts on the AXP813. > > These include the GPIO, ADC, AC and battery power supplies. > > > > Signed-off-by: Oskari Lemmela <oskari@lemmela.net> > > Reviewed-by: Chen-Yu Tsai <wens@csie.org> > > Tested-by: Vasily Khoruzhick <anarsoul@gmail.com> > > Signed-off-by: Chen-Yu Tsai <wens@csie.org> > > I'm happy to fix this, but ... > > Can you explain these tags for me please? > > Specifically the last one. > > Why does Chen-Yu Tsai have an SoB there? I picked his patch to rebase off the previous one, and reworked the ordering. I then pushed it onto GitHub [1], but didn't get around to sending it to the mailing lists. Oskari said on IRC that he would handle it. I'm not sure what would be appropriate here though? Oskari's first SoB should be kept, since he's the original author. Maybe he should've added his SoB again as the final entry? Either way I suppose it would be confusing without any explanation. ChenYu [1] https://github.com/wens/linux/commit/951afe2dc32086174ab07a1a997d748f69bf5bf2 [2] https://freenode.irclog.whitequark.org/linux-sunxi/2018-12-08#23644905;
On Mon, 10 Dec 2018, Chen-Yu Tsai wrote: > On Mon, Dec 10, 2018 at 2:35 PM Lee Jones <lee.jones@linaro.org> wrote: > > > > On Sat, 08 Dec 2018, Oskari Lemmela wrote: > > > > > Parts of the AXP803 are compatible with their counterparts on the AXP813. > > > These include the GPIO, ADC, AC and battery power supplies. > > > > > > Signed-off-by: Oskari Lemmela <oskari@lemmela.net> > > > Reviewed-by: Chen-Yu Tsai <wens@csie.org> > > > Tested-by: Vasily Khoruzhick <anarsoul@gmail.com> > > > Signed-off-by: Chen-Yu Tsai <wens@csie.org> > > > > I'm happy to fix this, but ... > > > > Can you explain these tags for me please? > > > > Specifically the last one. > > > > Why does Chen-Yu Tsai have an SoB there? > > I picked his patch to rebase off the previous one, and reworked the ordering. > I then pushed it onto GitHub [1], but didn't get around to sending it to the > mailing lists. Oskari said on IRC that he would handle it. > > I'm not sure what would be appropriate here though? Oskari's first SoB should > be kept, since he's the original author. Maybe he should've added his SoB > again as the final entry? Either way I suppose it would be confusing without > any explanation. Yes, I agree, but thanks for taking the time to do so. Let's leave it as it is. > [1] https://github.com/wens/linux/commit/951afe2dc32086174ab07a1a997d748f69bf5bf2 > [2] https://freenode.irclog.whitequark.org/linux-sunxi/2018-12-08#23644905;
diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c index 8037b4e01ed6..f8e0fa97bb31 100644 --- a/drivers/mfd/axp20x.c +++ b/drivers/mfd/axp20x.c @@ -726,6 +726,20 @@ static const struct mfd_cell axp803_cells[] = { .name = "axp221-pek", .num_resources = ARRAY_SIZE(axp803_pek_resources), .resources = axp803_pek_resources, + }, { + .name = "axp20x-gpio", + .of_compatible = "x-powers,axp813-gpio", + }, { + .name = "axp813-adc", + .of_compatible = "x-powers,axp813-adc", + }, { + .name = "axp20x-battery-power-supply", + .of_compatible = "x-powers,axp813-battery-power-supply", + }, { + .name = "axp20x-ac-power-supply", + .of_compatible = "x-powers,axp813-ac-power-supply", + .num_resources = ARRAY_SIZE(axp20x_ac_power_supply_resources), + .resources = axp20x_ac_power_supply_resources, }, { .name = "axp20x-regulator" }, };