From: tip-bot for Masahiro Yamada <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: bp@suse.de, richard@nod.at, mpe@ellerman.id.au, x86@kernel.org,
hpa@zytor.com, tglx@linutronix.de, mingo@redhat.com,
yamada.masahiro@socionext.com, linux-kernel@vger.kernel.org,
mingo@kernel.org
Subject: [tip:x86/build] x86/um: Remove -fno-unit-at-a-time workaround for pre-4.0 GCC
Date: Sun, 9 Dec 2018 03:06:57 -0800 [thread overview]
Message-ID: <tip-829889ac4a7d26858860c297e64051bd27ce8fbe@git.kernel.org> (raw)
In-Reply-To: <1541990120-9643-2-git-send-email-yamada.masahiro@socionext.com>
Commit-ID: 829889ac4a7d26858860c297e64051bd27ce8fbe
Gitweb: https://git.kernel.org/tip/829889ac4a7d26858860c297e64051bd27ce8fbe
Author: Masahiro Yamada <yamada.masahiro@socionext.com>
AuthorDate: Mon, 12 Nov 2018 11:35:19 +0900
Committer: Borislav Petkov <bp@suse.de>
CommitDate: Sun, 9 Dec 2018 11:51:11 +0100
x86/um: Remove -fno-unit-at-a-time workaround for pre-4.0 GCC
Commit
cafa0010cd51 ("Raise the minimum required gcc version to 4.6")
bumped the minimum GCC version to 4.6 for all architectures.
'$(call cc-option,-fno-unit-at-a-time)' is now dead code since
'$(cc-version) -lt 0400' is always false. Remove it.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
Acked-by: Richard Weinberger <richard@nod.at>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: linuxppc-dev@lists.ozlabs.org
Cc: x86-ml <x86@kernel.org>
Link: https://lkml.kernel.org/r/1541990120-9643-2-git-send-email-yamada.masahiro@socionext.com
---
arch/x86/Makefile.um | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/arch/x86/Makefile.um b/arch/x86/Makefile.um
index 91085a08de6c..577976b7d1f8 100644
--- a/arch/x86/Makefile.um
+++ b/arch/x86/Makefile.um
@@ -26,12 +26,8 @@ cflags-y += $(call cc-option,-mpreferred-stack-boundary=2)
# an unresolved reference.
cflags-y += -ffreestanding
-# Disable unit-at-a-time mode on pre-gcc-4.0 compilers, it makes gcc use
-# a lot more stack due to the lack of sharing of stacklots. Also, gcc
-# 4.3.0 needs -funit-at-a-time for extern inline functions.
-KBUILD_CFLAGS += $(shell if [ $(cc-version) -lt 0400 ] ; then \
- echo $(call cc-option,-fno-unit-at-a-time); \
- else echo $(call cc-option,-funit-at-a-time); fi ;)
+# gcc 4.3.0 needs -funit-at-a-time for extern inline functions.
+KBUILD_CFLAGS += $(call cc-option,-funit-at-a-time)
KBUILD_CFLAGS += $(cflags-y)
next prev parent reply other threads:[~2018-12-09 11:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-12 2:35 [PATCH 0/2] Remove -fno-unit-at-a-time and -funit-at-a-time compiler flags entirely Masahiro Yamada
2018-11-12 2:35 ` [PATCH 1/2] um: remove -fno-unit-at-a-time workaround for pre-4.0 GCC Masahiro Yamada
2018-11-13 9:47 ` Richard Weinberger
2018-12-08 6:35 ` Masahiro Yamada
2018-12-08 8:54 ` Richard Weinberger
2018-12-08 19:18 ` Masahiro Yamada
2018-12-09 11:06 ` tip-bot for Masahiro Yamada [this message]
2018-11-12 2:35 ` [PATCH 2/2] x86, powerpc: remove -funit-at-a-time compiler option entirely Masahiro Yamada
2018-11-12 3:01 ` Ingo Molnar
2018-11-12 11:22 ` Michael Ellerman
2018-12-08 6:36 ` Masahiro Yamada
2018-12-08 11:33 ` Borislav Petkov
2018-12-08 19:17 ` Masahiro Yamada
2018-12-09 11:07 ` [tip:x86/build] x86, powerpc: Remove " tip-bot for Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-829889ac4a7d26858860c297e64051bd27ce8fbe@git.kernel.org \
--to=tipbot@zytor.com \
--cc=bp@suse.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=richard@nod.at \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).