[1/3] phy: make phy-core explicitly non-modular
diff mbox series

Message ID 1544402090-30970-2-git-send-email-paul.gortmaker@windriver.com
State Accepted
Commit cc013c285e3f6c3b7d8b15d39fa53848f9013990
Headers show
  • phy: remove needless usage of module header
Related show

Commit Message

Paul Gortmaker Dec. 10, 2018, 12:34 a.m. UTC
The Kconfig currently controlling compilation of this code is:

drivers/phy/Kconfig:config GENERIC_PHY
drivers/phy/Kconfig:    bool "PHY Core"

...meaning that it currently is not being built as a module by anyone.

Lets remove the modular code that is essentially orphaned, so that
when reading the driver there is no doubt it is builtin-only.

Since module_init translates to device_initcall in the non-modular
case, the init ordering remains unchanged with this commit.

We don't remove module.h since the file is using other modular fcns
(to load other phy modules) even though the core support itself is

We also delete the MODULE_LICENSE tag etc. since all that information
is already contained at the top of the file in the comments.

Cc: Kishon Vijay Abraham I <kishon@ti.com>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
 drivers/phy/phy-core.c | 12 +-----------
 1 file changed, 1 insertion(+), 11 deletions(-)

diff mbox series

diff --git a/drivers/phy/phy-core.c b/drivers/phy/phy-core.c
index df3d4ba516ab..f10110676572 100644
--- a/drivers/phy/phy-core.c
+++ b/drivers/phy/phy-core.c
@@ -1048,14 +1048,4 @@  static int __init phy_core_init(void)
 	return 0;
-static void __exit phy_core_exit(void)
-	class_destroy(phy_class);
-MODULE_DESCRIPTION("Generic PHY Framework");
-MODULE_AUTHOR("Kishon Vijay Abraham I <kishon@ti.com>");