[1/5] switchtec: Remove immediate status check after submit a MRPC command
diff mbox series

Message ID 1544433144-7563-2-git-send-email-wesley.sheng@microchip.com
State In Next
Commit 526180408b815aa7b96fd48bd23cdd33ef04e38e
Headers show
  • Switchtec MRPC DMA mode support
Related show

Commit Message

Wesley Sheng Dec. 10, 2018, 9:12 a.m. UTC
From: Kelvin Cao <kelvin.cao@microchip.com>

After submitting a Firmware Download MRPC command, Switchtec firmware will
delay Management EP BAR MemRd TLP responses by more than 10ms. This is a
firmware limitation. Delayed MemRd completions are problem for systems with
a low Completion Timeout (CTO).

The current driver checks the MRPC status immediately after submitting an
MRPC command, which results in the MemRd TLP that's affected by the above

Remove the immediate status check and rely on the check after receiving an
interrupt or timing out.

This is only a software workaround to the READ issue and a proper fix of
this should be done in firmware.

Fixes: 080b47def5e5 ("MicroSemi Switchtec management interface driver")
Signed-off-by: Kelvin Cao <kelvin.cao@microchip.com>
Signed-off-by: Wesley Sheng <wesley.sheng@microchip.com>
Reviewed-by: Logan Gunthorpe <logang@deltatee.com>
 drivers/pci/switch/switchtec.c | 4 ----
 1 file changed, 4 deletions(-)

diff mbox series

diff --git a/drivers/pci/switch/switchtec.c b/drivers/pci/switch/switchtec.c
index 54a8b30..d2bca2d 100644
--- a/drivers/pci/switch/switchtec.c
+++ b/drivers/pci/switch/switchtec.c
@@ -134,10 +134,6 @@  static void mrpc_cmd_submit(struct switchtec_dev *stdev)
 		    stuser->data, stuser->data_len);
 	iowrite32(stuser->cmd, &stdev->mmio_mrpc->cmd);
-	stuser->status = ioread32(&stdev->mmio_mrpc->status);
-		mrpc_complete_cmd(stdev);