From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Pavel Machek <pavel@ucw.cz>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Baolin Wang <baolin.wang@linaro.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v2 1/5] led: triggers: Break the for loop after default trigger is found
Date: Mon, 10 Dec 2018 10:29:57 +0100 [thread overview]
Message-ID: <1544434201-14190-2-git-send-email-krzk@kernel.org> (raw)
In-Reply-To: <1544434201-14190-1-git-send-email-krzk@kernel.org>
From: Jacek Anaszewski <jacek.anaszewski@gmail.com>
It is of no avail to continue iterating through registered
triggers in the led_trigger_set_default() after the trigger to set
has been found. Add "break" statement to fix this omission.
Signed-off-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/leds/led-triggers.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/leds/led-triggers.c b/drivers/leds/led-triggers.c
index 17d73db1456e..52b12e601ebe 100644
--- a/drivers/leds/led-triggers.c
+++ b/drivers/leds/led-triggers.c
@@ -200,8 +200,10 @@ void led_trigger_set_default(struct led_classdev *led_cdev)
down_read(&triggers_list_lock);
down_write(&led_cdev->trigger_lock);
list_for_each_entry(trig, &trigger_list, next_trig) {
- if (!strcmp(led_cdev->default_trigger, trig->name))
+ if (!strcmp(led_cdev->default_trigger, trig->name)) {
led_trigger_set(led_cdev, trig);
+ break;
+ }
}
up_write(&led_cdev->trigger_lock);
up_read(&triggers_list_lock);
--
2.7.4
next prev parent reply other threads:[~2018-12-10 9:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-10 9:29 [PATCH v2 0/5] leds: trigger: Add pattern initialization from Device Tree Krzysztof Kozlowski
2018-12-10 9:29 ` Krzysztof Kozlowski [this message]
2018-12-10 9:29 ` [PATCH v2 2/5] led: triggers: Add LED_INIT_DEFAULT_TRIGGER flag Krzysztof Kozlowski
2018-12-10 9:29 ` [PATCH v2 3/5] led: triggers: Initialize LED_INIT_DEFAULT_TRIGGER if trigger is brought after class Krzysztof Kozlowski
2018-12-10 9:30 ` [PATCH v2 4/5] dt-bindings: leds: Add pattern initialization from Device Tree Krzysztof Kozlowski
2018-12-11 17:23 ` Rob Herring
2018-12-12 8:42 ` Krzysztof Kozlowski
2018-12-10 9:30 ` [PATCH v2 5/5] leds: trigger: " Krzysztof Kozlowski
2018-12-10 21:03 ` [PATCH v2 0/5] " Jacek Anaszewski
2018-12-12 12:16 ` Pavel Machek
2018-12-12 19:18 ` Jacek Anaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1544434201-14190-2-git-send-email-krzk@kernel.org \
--to=krzk@kernel.org \
--cc=baolin.wang@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).