gpio: raspberrypi-exp: decrease refcount on firmware dt node
diff mbox series

Message ID 20181210165005.27965-1-nsaenzjulienne@suse.de
State Accepted
Commit 85af74c474b21940e88483fd48f6094145c89d97
Headers show
Series
  • gpio: raspberrypi-exp: decrease refcount on firmware dt node
Related show

Commit Message

Nicolas Saenz Julienne Dec. 10, 2018, 4:50 p.m. UTC
We're getting a reference RPi's firmware node in order to be able to
communicate with it's driver. We should decrease the reference count on
the dt node after being done with it.

Fixes: a98d90e7d588 ("gpio: raspberrypi-exp: Driver for RPi3 GPIO expander via mailbox service")
Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
---
 drivers/gpio/gpio-raspberrypi-exp.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Linus Walleij Dec. 16, 2018, 12:20 a.m. UTC | #1
On Mon, Dec 10, 2018 at 5:50 PM Nicolas Saenz Julienne
<nsaenzjulienne@suse.de> wrote:

> We're getting a reference RPi's firmware node in order to be able to
> communicate with it's driver. We should decrease the reference count on
> the dt node after being done with it.
>
> Fixes: a98d90e7d588 ("gpio: raspberrypi-exp: Driver for RPi3 GPIO expander via mailbox service")
> Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>

Patch applied.

Yours,
Linus Walleij

Patch
diff mbox series

diff --git a/drivers/gpio/gpio-raspberrypi-exp.c b/drivers/gpio/gpio-raspberrypi-exp.c
index d6d36d537e37..b77ea16ffa03 100644
--- a/drivers/gpio/gpio-raspberrypi-exp.c
+++ b/drivers/gpio/gpio-raspberrypi-exp.c
@@ -206,6 +206,7 @@  static int rpi_exp_gpio_probe(struct platform_device *pdev)
 	}
 
 	fw = rpi_firmware_get(fw_node);
+	of_node_put(fw_node);
 	if (!fw)
 		return -EPROBE_DEFER;