linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rajendra Nayak <rnayak@codeaurora.org>
To: andy.gross@linaro.org, robh@kernel.org, viresh.kumar@linaro.org,
	sboyd@kernel.org, ulf.hansson@linaro.org,
	collinsd@codeaurora.org, mka@chromium.org
Cc: devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Rajendra Nayak <rnayak@codeaurora.org>
Subject: [PATCH v6 10/10] soc: qcom: rpmhpd: Mark mx as a parent for cx
Date: Tue, 11 Dec 2018 15:19:38 +0530	[thread overview]
Message-ID: <20181211094938.25086-11-rnayak@codeaurora.org> (raw)
In-Reply-To: <20181211094938.25086-1-rnayak@codeaurora.org>

Specify the active + sleep and active-only MX power domains as
the parents of the corresponding CX power domains. This will ensure that
performance state requests on CX automatically generate equivalent requests
on MX power domains.

This is used to enforce a requirement that exists for various
hardware blocks on SDM845 that MX performance state >= CX performance
state for a given operating frequency.

Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
---
This patch is dependent on the series from
Viresh [1] which adds support to propogate performance states across the
power domain hierarchy which is still being reviewed.

[1] https://lkml.org/lkml/2018/11/26/333

 drivers/soc/qcom/rpmhpd.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/drivers/soc/qcom/rpmhpd.c b/drivers/soc/qcom/rpmhpd.c
index 1ce86f0cc9fa..af7b07d49e4f 100644
--- a/drivers/soc/qcom/rpmhpd.c
+++ b/drivers/soc/qcom/rpmhpd.c
@@ -102,12 +102,14 @@ static struct rpmhpd sdm845_cx_ao;
 static struct rpmhpd sdm845_cx = {
 	.pd = { .name = "cx", },
 	.peer = &sdm845_cx_ao,
+	.parent = &sdm845_mx.pd,
 	.res_name = "cx.lvl",
 };
 
 static struct rpmhpd sdm845_cx_ao = {
 	.pd = { .name = "cx_ao", },
 	.peer = &sdm845_cx,
+	.parent = &sdm845_mx_ao.pd,
 	.res_name = "cx.lvl",
 };
 
@@ -389,6 +391,15 @@ static int rpmhpd_probe(struct platform_device *pdev)
 		data->domains[i] = &rpmhpds[i]->pd;
 	}
 
+	/* Add subdomains */
+	for (i = 0; i < num_pds; i++) {
+		if (!rpmhpds[i])
+			continue;
+		if (rpmhpds[i]->parent)
+			pm_genpd_add_subdomain(rpmhpds[i]->parent,
+					       &rpmhpds[i]->pd);
+	}
+
 	return of_genpd_add_provider_onecell(pdev->dev.of_node, data);
 }
 
-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation


  parent reply	other threads:[~2018-12-11  9:50 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-11  9:49 [PATCH v6 00/10] Add power domain driver for corners on msm8996/sdm845 Rajendra Nayak
2018-12-11  9:49 ` [PATCH v6 01/10] dt-bindings: opp: Introduce qcom-opp bindings Rajendra Nayak
2018-12-11  9:49 ` [PATCH v6 02/10] dt-bindings: power: Add qcom rpm power domain driver bindings Rajendra Nayak
2018-12-11 21:28   ` Stephen Boyd
2018-12-11  9:49 ` [PATCH v6 03/10] soc: qcom: rpmpd: Add a Power domain driver to model corners Rajendra Nayak
2018-12-11 21:52   ` Stephen Boyd
2018-12-11  9:49 ` [PATCH v6 04/10] soc: qcom: rpmpd: Add support for get/set performance state Rajendra Nayak
2018-12-11  9:49 ` [PATCH v6 05/10] arm64: dts: msm8996: Add rpmpd device node Rajendra Nayak
2018-12-11 21:53   ` Stephen Boyd
2018-12-11  9:49 ` [PATCH v6 06/10] soc: qcom: rpmhpd: Add RPMh power domain driver Rajendra Nayak
2018-12-11 22:01   ` Stephen Boyd
2018-12-12  5:04     ` Rajendra Nayak
2018-12-11  9:49 ` [PATCH v6 07/10] arm64: dts: sdm845: Add rpmh powercontroller node Rajendra Nayak
2018-12-11 22:01   ` Stephen Boyd
2018-12-11  9:49 ` [PATCH v6 08/10] PM / Domains: Add a simple_opp_to_performance_state() helper Rajendra Nayak
2018-12-11 21:33   ` Stephen Boyd
2018-12-11  9:49 ` [PATCH v6 09/10] soc: qcom: rpmpd: Use " Rajendra Nayak
2018-12-11 21:34   ` Stephen Boyd
2018-12-11  9:49 ` Rajendra Nayak [this message]
2018-12-11 10:22   ` [PATCH v6 10/10] soc: qcom: rpmhpd: Mark mx as a parent for cx Ulf Hansson
2018-12-11 10:33     ` Rajendra Nayak
2018-12-11 21:50       ` Stephen Boyd
2018-12-12  4:13         ` Rajendra Nayak
2018-12-12 18:32           ` Stephen Boyd
2018-12-13 16:02             ` Ulf Hansson
2018-12-11 21:51 ` [PATCH v6 00/10] Add power domain driver for corners on msm8996/sdm845 Stephen Boyd
2018-12-12  4:17   ` Rajendra Nayak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181211094938.25086-11-rnayak@codeaurora.org \
    --to=rnayak@codeaurora.org \
    --cc=andy.gross@linaro.org \
    --cc=collinsd@codeaurora.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mka@chromium.org \
    --cc=robh@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=ulf.hansson@linaro.org \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).