clk: qcom: Drop unused 8998 clock
diff mbox series

Message ID 1544719454-10638-1-git-send-email-jhugo@codeaurora.org
State Superseded
Commit 0f1c6ca83fb483a5ea85fe239588a90bb29d519d
Headers show
Series
  • clk: qcom: Drop unused 8998 clock
Related show

Commit Message

Jeffrey Hugo Dec. 13, 2018, 4:44 p.m. UTC
gcc_lpass_trig_clk is not used downstream, therefore there is no reason to
expect it to be needed for clients.  Lets remove it because messing with
the clock has been observed to cause Linux hangs when the qdss_clk is
initialized by rpmcc.

Signed-off-by: Jeffrey Hugo <jhugo@codeaurora.org>
---
 drivers/clk/qcom/gcc-msm8998.c | 14 --------------
 1 file changed, 14 deletions(-)

Comments

Marc Gonzalez Dec. 13, 2018, 4:52 p.m. UTC | #1
On 13/12/2018 17:44, Jeffrey Hugo wrote:

> gcc_lpass_trig_clk is not used downstream, therefore there is no reason to
> expect it to be needed for clients.  Lets remove it because messing with

"Let's" ;-p

> the clock has been observed to cause Linux hangs when the qdss_clk is
> initialized by rpmcc.
> 
> Signed-off-by: Jeffrey Hugo <jhugo@codeaurora.org>
> ---
>  drivers/clk/qcom/gcc-msm8998.c | 14 --------------
>  1 file changed, 14 deletions(-)

Reviewed-by: Marc Gonzalez <marc.w.gonzalez@free.fr>

Regards.
Stephen Boyd Dec. 13, 2018, 7:37 p.m. UTC | #2
Quoting Jeffrey Hugo (2018-12-13 08:44:14)
> gcc_lpass_trig_clk is not used downstream, therefore there is no reason to
> expect it to be needed for clients.  Lets remove it because messing with
> the clock has been observed to cause Linux hangs when the qdss_clk is
> initialized by rpmcc.
> 
> Signed-off-by: Jeffrey Hugo <jhugo@codeaurora.org>

Fixes tag?

Patch
diff mbox series

diff --git a/drivers/clk/qcom/gcc-msm8998.c b/drivers/clk/qcom/gcc-msm8998.c
index f3c2ab4..4b75a09 100644
--- a/drivers/clk/qcom/gcc-msm8998.c
+++ b/drivers/clk/qcom/gcc-msm8998.c
@@ -2005,19 +2005,6 @@  enum {
 	},
 };
 
-static struct clk_branch gcc_lpass_trig_clk = {
-	.halt_reg = 0x4701c,
-	.halt_check = BRANCH_HALT,
-	.clkr = {
-		.enable_reg = 0x4701c,
-		.enable_mask = BIT(0),
-		.hw.init = &(struct clk_init_data){
-			.name = "gcc_lpass_trig_clk",
-			.ops = &clk_branch2_ops,
-		},
-	},
-};
-
 static struct clk_branch gcc_mmss_noc_cfg_ahb_clk = {
 	.halt_reg = 0x9004,
 	.halt_check = BRANCH_HALT,
@@ -2710,7 +2697,6 @@  enum {
 	[GCC_HMSS_AT_CLK] = &gcc_hmss_at_clk.clkr,
 	[GCC_HMSS_RBCPR_CLK] = &gcc_hmss_rbcpr_clk.clkr,
 	[GCC_HMSS_TRIG_CLK] = &gcc_hmss_trig_clk.clkr,
-	[GCC_LPASS_TRIG_CLK] = &gcc_lpass_trig_clk.clkr,
 	[GCC_MMSS_NOC_CFG_AHB_CLK] = &gcc_mmss_noc_cfg_ahb_clk.clkr,
 	[GCC_MMSS_QM_AHB_CLK] = &gcc_mmss_qm_ahb_clk.clkr,
 	[GCC_MMSS_QM_CORE_CLK] = &gcc_mmss_qm_core_clk.clkr,