From: Amir Mahdi Ghorbanian <indigoomega021@gmail.com>
To: marvin24@gmx.de
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
gregkh@linuxfoundation.org, ac100@lists.launchpad.net,
linux-tegra@vger.kernel.org
Subject: [PATCH 2/2] Staging: nvec: nvec: fixed check style issues
Date: Sun, 16 Dec 2018 08:57:43 -0800 [thread overview]
Message-ID: <1544979463-10126-1-git-send-email-indigoomega021@gmail.com> (raw)
Fixed an endline open parenthesis issue and replaced udelay() by the
preferred usleep_range() function.
Signed-off-by: Amir Mahdi Ghorbanian <indigoomega021@gmail.com>
---
drivers/staging/nvec/nvec.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
index 08027a3..69eef7d 100644
--- a/drivers/staging/nvec/nvec.c
+++ b/drivers/staging/nvec/nvec.c
@@ -382,8 +382,10 @@ static void nvec_request_master(struct work_struct *work)
msg = list_first_entry(&nvec->tx_data, struct nvec_msg, node);
spin_unlock_irqrestore(&nvec->tx_lock, flags);
nvec_gpio_set_value(nvec, 0);
- err = wait_for_completion_interruptible_timeout(
- &nvec->ec_transfer, msecs_to_jiffies(5000));
+ done = &nvec->ec_transfer;
+ timeout = msecs_to_jiffies(5000);
+ err = wait_for_completion_interruptible_timeout(done,
+ timeout);
if (err == 0) {
dev_warn(nvec->dev, "timeout waiting for ec transfer\n");
@@ -626,7 +628,7 @@ static irqreturn_t nvec_interrupt(int irq, void *dev)
break;
case 2: /* first byte after command */
if (status == (I2C_SL_IRQ | RNW | RCVD)) {
- udelay(33);
+ usleep_range(0, 33);
if (nvec->rx->data[0] != 0x01) {
dev_err(nvec->dev,
"Read without prior read command\n");
@@ -713,7 +715,7 @@ static irqreturn_t nvec_interrupt(int irq, void *dev)
* We experience less incomplete messages with this delay than without
* it, but we don't know why. Help is appreciated.
*/
- udelay(100);
+ usleep_range(0, 100);
return IRQ_HANDLED;
}
--
2.7.4
next reply other threads:[~2018-12-16 16:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-16 16:57 Amir Mahdi Ghorbanian [this message]
2018-12-16 17:47 ` [PATCH 2/2] Staging: nvec: nvec: fixed check style issues Joe Perches
2018-12-17 1:07 ` kbuild test robot
2018-12-17 8:16 ` Greg KH
2018-12-17 19:48 ` Marc Dietrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1544979463-10126-1-git-send-email-indigoomega021@gmail.com \
--to=indigoomega021@gmail.com \
--cc=ac100@lists.launchpad.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=marvin24@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).