[PATCH -next] drm/shmob: Fix return value check in shmob_drm_probe

From: YueHaibing <yuehaibing@huawei.com>
To: <laurent.pinchart@ideasonboard.com>,
	<kieran.bingham+renesas@ideasonboard.com>, <airlied@linux.ie>,
	<daniel@ffwll.ch>
Cc: <linux-kernel@vger.kernel.org>,
	<linux-renesas-soc@vger.kernel.org>,
	<dri-devel@lists.freedesktop.org>,
	YueHaibing <yuehaibing@huawei.com>
Subject: [PATCH -next] drm/shmob: Fix return value check in shmob_drm_probe
Date: Mon, 17 Dec 2018 17:18:30 +0800	[thread overview]
Message-ID: <20181217091830.32624-1-yuehaibing@huawei.com> (raw)

In case of error, the function devm_ioremap_resource() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check should
be replaced with IS_ERR().

Fixes: 8f1597c8f1a5 ("drm: shmobile: Perform initialization/cleanup at probe/remove time")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/gpu/drm/shmobile/shmob_drm_drv.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/shmobile/shmob_drm_drv.c b/drivers/gpu/drm/shmobile/shmob_drm_drv.c
index 8554102..f2cfd16 100644
--- a/drivers/gpu/drm/shmobile/shmob_drm_drv.c
+++ b/drivers/gpu/drm/shmobile/shmob_drm_drv.c
@@ -229,8 +229,8 @@ static int shmob_drm_probe(struct platform_device *pdev)
 
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	sdev->mmio = devm_ioremap_resource(&pdev->dev, res);
-	if (sdev->mmio == NULL)
-		return -ENOMEM;
+	if (IS_ERR(sdev->mmio))
+		return PTR_ERR(sdev->mmio);
 
 	ret = shmob_drm_setup_clocks(sdev, pdata->clk_source);
 	if (ret < 0)
-- 
2.7.0


