linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Popa <stefan.popa@analog.com>
To: <jic23@kernel.org>, <robh+dt@kernel.org>, <mark.rutland@arm.com>
Cc: Stefan Popa <stefan.popa@analog.com>,
	<Michael.Hennerich@analog.com>, <knaack.h@gmx.de>,
	<lars@metafoo.de>, <pmeerw@pmeerw.net>,
	<gregkh@linuxfoundation.org>, <linux-kernel@vger.kernel.org>,
	<linux-iio@vger.kernel.org>, <devel@driverdev.osuosl.org>
Subject: [PATCH v2 1/6] staging: iio: adc: ad7606: Simplify the Kconfing menu
Date: Mon, 17 Dec 2018 14:23:35 +0200	[thread overview]
Message-ID: <1545049420-16484-2-git-send-email-stefan.popa@analog.com> (raw)
In-Reply-To: <1545049420-16484-1-git-send-email-stefan.popa@analog.com>

There is no point in having three menu entries that can be selected
individually. Instead, the SPI and parallel interfaces should select
AD7606.

Signed-off-by: Stefan Popa <stefan.popa@analog.com>
---
 drivers/staging/iio/adc/Kconfig | 27 ++++++++++-----------------
 1 file changed, 10 insertions(+), 17 deletions(-)

diff --git a/drivers/staging/iio/adc/Kconfig b/drivers/staging/iio/adc/Kconfig
index fc23059..302639a 100644
--- a/drivers/staging/iio/adc/Kconfig
+++ b/drivers/staging/iio/adc/Kconfig
@@ -4,35 +4,28 @@
 menu "Analog to digital converters"
 
 config AD7606
-	tristate "Analog Devices AD7606 ADC driver"
-	depends on GPIOLIB || COMPILE_TEST
-	depends on HAS_IOMEM
+	tristate
 	select IIO_BUFFER
 	select IIO_TRIGGERED_BUFFER
-	help
-	  Say yes here to build support for Analog Devices:
-	  ad7605-4, ad7606, ad7606-6, ad7606-4 analog to digital converters (ADC).
-
-	  To compile this driver as a module, choose M here: the
-	  module will be called ad7606.
 
 config AD7606_IFACE_PARALLEL
-	tristate "parallel interface support"
-	depends on AD7606
+	tristate "Analog Devices AD7606 ADC driver with parallel interface support"
+	depends on HAS_IOMEM
+	select AD7606
 	help
-	  Say yes here to include parallel interface support on the AD7606
-	  ADC driver.
+	  Say yes here to build parallel interface support for Analog Devices:
+	  ad7605-4, ad7606, ad7606-6, ad7606-4 analog to digital converters (ADC).
 
 	  To compile this driver as a module, choose M here: the
 	  module will be called ad7606_parallel.
 
 config AD7606_IFACE_SPI
-	tristate "spi interface support"
-	depends on AD7606
+	tristate "Analog Devices AD7606 ADC driver with spi interface support"
 	depends on SPI
+	select AD7606
 	help
-	  Say yes here to include parallel interface support on the AD7606
-	  ADC driver.
+	  Say yes here to build spi interface support for Analog Devices:
+	  ad7605-4, ad7606, ad7606-6, ad7606-4 analog to digital converters (ADC).
 
 	  To compile this driver as a module, choose M here: the
 	  module will be called ad7606_spi.
-- 
2.7.4


  reply	other threads:[~2018-12-17 12:24 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-17 12:23 [PATCH v2 0/6] staging: iio: ad7606: Move out of staging Stefan Popa
2018-12-17 12:23 ` Stefan Popa [this message]
2018-12-22 17:40   ` [PATCH v2 1/6] staging: iio: adc: ad7606: Simplify the Kconfing menu Jonathan Cameron
2018-12-17 12:23 ` [PATCH v2 2/6] staging: iio: adc: ad7606: Use SPDX identifier Stefan Popa
2018-12-22 17:47   ` Jonathan Cameron
2018-12-17 12:23 ` [PATCH v2 3/6] staging: iio: adc: ad7606: Add support for threaded irq Stefan Popa
2018-12-22 17:49   ` Jonathan Cameron
2018-12-17 12:23 ` [PATCH v2 4/6] staging: iio: adc: ad7606: Misc style fixes (no functional change) Stefan Popa
2018-12-22 17:50   ` Jonathan Cameron
2018-12-17 12:23 ` [PATCH v2 5/6] staging: iio: adc: ad7606: Move out of staging Stefan Popa
2018-12-22 17:56   ` Jonathan Cameron
2018-12-17 12:23 ` [PATCH v2 6/6] dt-bindings: iio: adc: Add docs for AD7606 ADC Stefan Popa
2018-12-22 17:58   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1545049420-16484-2-git-send-email-stefan.popa@analog.com \
    --to=stefan.popa@analog.com \
    --cc=Michael.Hennerich@analog.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jic23@kernel.org \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=pmeerw@pmeerw.net \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).