From: Peng Li <lipeng321@huawei.com>
To: <davem@davemloft.net>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linuxarm@huawei.com>, <yisen.zhuang@huawei.com>,
<salil.mehta@huawei.com>, <lipeng321@huawei.com>
Subject: [PATCH net-next 8/9] net: hns3: fix the descriptor index when get rss type
Date: Thu, 20 Dec 2018 11:52:05 +0800 [thread overview]
Message-ID: <1545277926-66432-9-git-send-email-lipeng321@huawei.com> (raw)
In-Reply-To: <1545277926-66432-1-git-send-email-lipeng321@huawei.com>
Driver gets rss information from the last descriptor of the packet.
When driver handle the rss type, ring->next_to_clean indicates the
first descriptor of next packet.
This patch fix the descriptor index with "ring->next_to_clean - 1".
Fixes: 232fc64b6e62 ("net: hns3: Add HW RSS hash information to RX skb")
Signed-off-by: Peng Li <lipeng321@huawei.com>
---
drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
index 624b8a7..d3b9aaf 100644
--- a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
+++ b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
@@ -2550,9 +2550,16 @@ static void hns3_set_gro_param(struct sk_buff *skb, u32 l234info,
static void hns3_set_rx_skb_rss_type(struct hns3_enet_ring *ring,
struct sk_buff *skb)
{
- struct hns3_desc *desc = &ring->desc[ring->next_to_clean];
struct hnae3_handle *handle = ring->tqp->handle;
enum pkt_hash_types rss_type;
+ struct hns3_desc *desc;
+ int last_bd;
+
+ /* When driver handle the rss type, ring->next_to_clean indicates the
+ * first descriptor of next packet, need -1 here.
+ */
+ last_bd = (ring->next_to_clean - 1 + ring->desc_num) % ring->desc_num;
+ desc = &ring->desc[last_bd];
if (le32_to_cpu(desc->rx.rss_hash))
rss_type = handle->kinfo.rss_type;
--
1.9.1
next prev parent reply other threads:[~2018-12-20 3:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-20 3:51 [PATCH net-next 0/9] net: hns3: code optimizations & bugfixes for HNS3 driver Peng Li
2018-12-20 3:51 ` [PATCH net-next 1/9] net: hns3: refine the handle for hns3_nic_net_open/stop() Peng Li
2018-12-20 3:51 ` [PATCH net-next 2/9] net: hns3: change default tc state to close Peng Li
2018-12-20 3:52 ` [PATCH net-next 3/9] net: hns3: fix a bug caused by udelay Peng Li
2018-12-20 3:52 ` [PATCH net-next 4/9] net: hns3: add max vector number check for pf Peng Li
2018-12-20 3:52 ` [PATCH net-next 5/9] net: hns3: reset tqp while doing DOWN operation Peng Li
2018-12-20 3:52 ` [PATCH net-next 6/9] net: hns3: fix vf id check issue when add flow director rule Peng Li
2018-12-20 3:52 ` [PATCH net-next 7/9] net: hns3: don't restore rules when flow director is disabled Peng Li
2018-12-20 3:52 ` Peng Li [this message]
2018-12-20 3:52 ` [PATCH net-next 9/9] net: hns3: remove redundant variable initialization Peng Li
2018-12-20 7:48 ` [PATCH net-next 0/9] net: hns3: code optimizations & bugfixes for HNS3 driver David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1545277926-66432-9-git-send-email-lipeng321@huawei.com \
--to=lipeng321@huawei.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=salil.mehta@huawei.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).