From: Yangtao Li <tiny.windzz@gmail.com>
To: guoren@kernel.org, arnd@arndb.de
Cc: linux-kernel@vger.kernel.org, Yangtao Li <tiny.windzz@gmail.com>
Subject: [PATCH] csky: fix refcount leak in setup_smp()
Date: Thu, 27 Dec 2018 11:27:11 -0500 [thread overview]
Message-ID: <20181227162711.7346-1-tiny.windzz@gmail.com> (raw)
The of_find_node_by_type() returns a node pointer with refcount
incremented, but there is the lack of use of the of_node_put() when
done. Add the missing of_node_put() to release the refcount.
Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
---
arch/csky/kernel/smp.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/arch/csky/kernel/smp.c b/arch/csky/kernel/smp.c
index 36ebaf9834e1..adec56df613b 100644
--- a/arch/csky/kernel/smp.c
+++ b/arch/csky/kernel/smp.c
@@ -139,11 +139,17 @@ void __init setup_smp(void)
int cpu;
while ((node = of_find_node_by_type(node, "cpu"))) {
- if (!of_device_is_available(node))
+ if (!of_device_is_available(node)) {
+ of_node_put(node);
continue;
+ }
- if (of_property_read_u32(node, "reg", &cpu))
+ if (of_property_read_u32(node, "reg", &cpu)) {
+ of_node_put(node);
continue;
+ }
+
+ of_node_put(node);
if (cpu >= NR_CPUS)
continue;
--
2.17.0
next reply other threads:[~2018-12-27 16:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-27 16:27 Yangtao Li [this message]
2018-12-27 17:02 ` [PATCH] csky: fix refcount leak in setup_smp() Guo Ren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181227162711.7346-1-tiny.windzz@gmail.com \
--to=tiny.windzz@gmail.com \
--cc=arnd@arndb.de \
--cc=guoren@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).