From: Jiri Olsa <jolsa@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: lkml <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Joe Mario <jmario@redhat.com>
Subject: [PATCH 1/2] perf c2c: Change the default coalesce setup
Date: Fri, 28 Dec 2018 11:18:19 +0100 [thread overview]
Message-ID: <20181228101820.28010-1-jolsa@kernel.org> (raw)
Joe suggested to have the coalesce default set just to 'iaddr',
because it's easier to read on the (default) c2c report run.
By removing pid from -c option, the c2c report will group all
the relevant pids under instruction address bucket. User can
always run -c pid,iaddr for more grained output on particular
pids.
Suggested-by: Joe Mario <jmario@redhat.com>
Link: http://lkml.kernel.org/n/tip-lk53c7y9fadu53spuzsn6cij@git.kernel.org
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
---
tools/perf/builtin-c2c.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/builtin-c2c.c b/tools/perf/builtin-c2c.c
index 686fb60a8e11..321687f8f373 100644
--- a/tools/perf/builtin-c2c.c
+++ b/tools/perf/builtin-c2c.c
@@ -68,7 +68,7 @@ struct c2c_hist_entry {
struct hist_entry he;
};
-static char const *coalesce_default = "pid,iaddr";
+static char const *coalesce_default = "iaddr";
struct perf_c2c {
struct perf_tool tool;
--
2.17.2
next reply other threads:[~2018-12-28 10:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-28 10:18 Jiri Olsa [this message]
2018-12-28 10:18 ` [PATCH 2/2] perf c2c: Increase the HITM ratio limit for displayed cachelines Jiri Olsa
2018-12-28 12:39 ` Arnaldo Carvalho de Melo
2019-01-03 13:19 ` [tip:perf/urgent] " tip-bot for Jiri Olsa
2018-12-28 12:34 ` [PATCH 1/2] perf c2c: Change the default coalesce setup Arnaldo Carvalho de Melo
2019-01-03 13:18 ` [tip:perf/urgent] " tip-bot for Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181228101820.28010-1-jolsa@kernel.org \
--to=jolsa@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=jmario@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).