From: Aaro Koskinen <aaro.koskinen@iki.fi>
To: "Theodore Y. Ts'o" <tytso@mit.edu>,
Jaegeuk Kim <jaegeuk@kernel.org>,
David Howells <dhowells@redhat.com>
Cc: linux-fscrypt@vger.kernel.org, linux-kernel@vger.kernel.org,
keyrings@vger.kernel.org
Subject: Bug report: unaligned access with ext4 encryption
Date: Sun, 30 Dec 2018 18:29:06 +0200 [thread overview]
Message-ID: <20181230162906.GI27785@darkstar.musicnaut.iki.fi> (raw)
Hi,
When using ext4 encryption on SPARC, there's plenty of dmesg noise about
unaligned access:
[ 167.269526] Kernel unaligned access at TPC[5497a0] find_and_lock_process_key+0x80/0x120
[ 167.270152] Kernel unaligned access at TPC[5497a0] find_and_lock_process_key+0x80/0x120
[ 181.087451] log_unaligned: 5 callbacks suppressed
[ 181.087511] Kernel unaligned access at TPC[5497a0] find_and_lock_process_key+0x80/0x120
[ 181.092435] Kernel unaligned access at TPC[5497a0] find_and_lock_process_key+0x80/0x120
[ 181.095816] Kernel unaligned access at TPC[5497a0] find_and_lock_process_key+0x80/0x120
And also seen on an ARM machine:
$ cat /proc/cpu/alignment
User: 0
System: 1028193 (find_and_lock_process_key+0x84/0x10c)
Skipped: 0
Half: 0
Word: 1028193
DWord: 0
Multi: 0
User faults: 0 (ignored)
Looks like user_key_payload layout is not optimal when data address
is used for fscrypt_key... I tried the below change and got rid of the
messages. Not sure what the proper fix should be?
A.
diff --git a/include/keys/user-type.h b/include/keys/user-type.h
index e098cbe27db5..6495ffcfe510 100644
--- a/include/keys/user-type.h
+++ b/include/keys/user-type.h
@@ -31,7 +31,7 @@
struct user_key_payload {
struct rcu_head rcu; /* RCU destructor */
unsigned short datalen; /* length of this data */
- char data[0]; /* actual data */
+ char data[0] __aligned(4); /* actual data */
};
extern struct key_type key_type_user;
next reply other threads:[~2018-12-30 16:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-30 16:29 Aaro Koskinen [this message]
2019-01-03 17:17 ` Bug report: unaligned access with ext4 encryption Eric Biggers
2019-01-04 17:28 ` David Howells
2019-01-10 22:29 ` Aaro Koskinen
2019-01-10 23:01 ` Eric Biggers
2019-01-10 23:35 ` Aaro Koskinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181230162906.GI27785@darkstar.musicnaut.iki.fi \
--to=aaro.koskinen@iki.fi \
--cc=dhowells@redhat.com \
--cc=jaegeuk@kernel.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-fscrypt@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).