From: tip-bot for Jiri Olsa <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: acme@redhat.com, mingo@kernel.org, hpa@zytor.com,
alexander.shishkin@linux.intel.com, peterz@infradead.org,
jmario@redhat.com, linux-kernel@vger.kernel.org,
jolsa@kernel.org, tglx@linutronix.de, namhyung@kernel.org
Subject: [tip:perf/urgent] perf c2c: Change the default coalesce setup
Date: Thu, 3 Jan 2019 05:18:52 -0800 [thread overview]
Message-ID: <tip-423701a0c8d754d9a39547f6c48904347e4f1eca@git.kernel.org> (raw)
In-Reply-To: <20181228101820.28010-1-jolsa@kernel.org>
Commit-ID: 423701a0c8d754d9a39547f6c48904347e4f1eca
Gitweb: https://git.kernel.org/tip/423701a0c8d754d9a39547f6c48904347e4f1eca
Author: Jiri Olsa <jolsa@kernel.org>
AuthorDate: Fri, 28 Dec 2018 11:18:19 +0100
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Fri, 28 Dec 2018 16:33:06 -0300
perf c2c: Change the default coalesce setup
Joe suggested to have the coalesce default set just to 'iaddr', because
it's easier to read on the default 'perf c2c report' output.
By removing the "pid" field from the default -c/--coalesce option, the
'perf c2c' report will group all the relevant PIDs under the instruction
address ('iaddr') bucket. User can always run "-c pid,iaddr" for a more
fine grained output on particular PIDs.
Suggested-by: Joe Mario <jmario@redhat.com>
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/20181228101820.28010-1-jolsa@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/builtin-c2c.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/builtin-c2c.c b/tools/perf/builtin-c2c.c
index f3aa9d02a5ab..964f3f5ef420 100644
--- a/tools/perf/builtin-c2c.c
+++ b/tools/perf/builtin-c2c.c
@@ -68,7 +68,7 @@ struct c2c_hist_entry {
struct hist_entry he;
};
-static char const *coalesce_default = "pid,iaddr";
+static char const *coalesce_default = "iaddr";
struct perf_c2c {
struct perf_tool tool;
prev parent reply other threads:[~2019-01-03 13:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-28 10:18 [PATCH 1/2] perf c2c: Change the default coalesce setup Jiri Olsa
2018-12-28 10:18 ` [PATCH 2/2] perf c2c: Increase the HITM ratio limit for displayed cachelines Jiri Olsa
2018-12-28 12:39 ` Arnaldo Carvalho de Melo
2019-01-03 13:19 ` [tip:perf/urgent] " tip-bot for Jiri Olsa
2018-12-28 12:34 ` [PATCH 1/2] perf c2c: Change the default coalesce setup Arnaldo Carvalho de Melo
2019-01-03 13:18 ` tip-bot for Jiri Olsa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-423701a0c8d754d9a39547f6c48904347e4f1eca@git.kernel.org \
--to=tipbot@zytor.com \
--cc=acme@redhat.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jmario@redhat.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).