[RFT] regulator: bcm590xx: Fix .enable_reg for BCM590XX_REG_VSR
diff mbox series

Message ID 20190105032817.13994-1-axel.lin@ingics.com
State Accepted
Commit d6afa2bed00486767fd5f3255cc89c05ccb70c0a
Headers show
  • [RFT] regulator: bcm590xx: Fix .enable_reg for BCM590XX_REG_VSR
Related show

Commit Message

Axel Lin Jan. 5, 2019, 3:28 a.m. UTC
Current implementation missed the case BCM590XX_REG_VSR, so
bcm590xx_get_enable_register() returns 0 when id is BCM590XX_REG_VSR.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Hi Matt,
Current code looks strange becasue bcm590xx_get_enable_register() returns 0
for BCM590XX_REG_VSR but there is a BCM590XX_VSRPMCTRL1 defined in the code.
I don't have the h/w, and I even cannot find the datasheet on the internet.
I might be wrong, but just in case this might fix a real bug.
Please help to review and test this patch.

 drivers/regulator/bcm590xx-regulator.c | 4 ++++
 1 file changed, 4 insertions(+)

diff mbox series

diff --git a/drivers/regulator/bcm590xx-regulator.c b/drivers/regulator/bcm590xx-regulator.c
index 92d6d7b10cf7..e49c0a7d5dd5 100644
--- a/drivers/regulator/bcm590xx-regulator.c
+++ b/drivers/regulator/bcm590xx-regulator.c
@@ -242,8 +242,12 @@  static int bcm590xx_get_enable_register(int id)
 		case BCM590XX_REG_SDSR2:
 			reg = BCM590XX_SDSR2PMCTRL1;
+		case BCM590XX_REG_VSR:
+			reg = BCM590XX_VSRPMCTRL1;
+			break;
 		case BCM590XX_REG_VBUS:
 			reg = BCM590XX_OTG_CTRL;
+			break;