From: Qian Cai <cai@lca.pw>
To: akpm@linux-foundation.org
Cc: linux-kernel@vger.kernel.org, Qian Cai <cai@lca.pw>
Subject: [PATCH] signal: allow the null signal in rt_sigqueueinfo()
Date: Sat, 5 Jan 2019 00:47:29 -0500 [thread overview]
Message-ID: <20190105054729.40397-1-cai@lca.pw> (raw)
Running the trinity fuzzer triggered this,
UBSAN: Undefined behaviour in kernel/signal.c:2946:7
shift exponent 4294967295 is too large for 64-bit type 'long unsigned
int'
[ 3752.406618] dump_stack+0xe0/0x17a
[ 3752.419817] ubsan_epilogue+0xd/0x4e
[ 3752.423429] __ubsan_handle_shift_out_of_bounds+0x1d6/0x227
[ 3752.447269] known_siginfo_layout.cold.9+0x16/0x1b
[ 3752.452105] __copy_siginfo_from_user+0x4b/0x70
[ 3752.466620] do_syscall_64+0x164/0x7ea
[ 3752.565030] entry_SYSCALL_64_after_hwframe+0x49/0xbe
This is because signo is 0 from userspace, and then it ends up calling
(1UL << -1) in sig_specific_sicodes(). Since the null signal (0) is
allowed in the spec, just deal with it accordingly.
Signed-off-by: Qian Cai <cai@lca.pw>
---
kernel/signal.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/signal.c b/kernel/signal.c
index e1d7ad8e6ab1..970bb36837a9 100644
--- a/kernel/signal.c
+++ b/kernel/signal.c
@@ -2943,7 +2943,7 @@ static bool known_siginfo_layout(unsigned sig, int si_code)
if (si_code == SI_KERNEL)
return true;
else if ((si_code > SI_USER)) {
- if (sig_specific_sicodes(sig)) {
+ if (sig && sig_specific_sicodes(sig)) {
if (si_code <= sig_sicodes[sig].limit)
return true;
}
--
2.17.2 (Apple Git-113)
next reply other threads:[~2019-01-05 5:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-05 5:47 Qian Cai [this message]
2019-01-07 23:03 ` [PATCH] signal: allow the null signal in rt_sigqueueinfo() Andrew Morton
2019-01-08 1:33 ` Qian Cai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190105054729.40397-1-cai@lca.pw \
--to=cai@lca.pw \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).