[3/3] dt-bindings: iio: chemical: pms7003: add device tree support
diff mbox series

Message ID 20190106171614.12615-4-tduszyns@gmail.com
State Superseded
Headers show
Series
  • add support for PMS7003 PM sensor
Related show

Commit Message

Tomasz Duszynski Jan. 6, 2019, 5:16 p.m. UTC
Add device tree support for Plantower PMS7003 particulate matter sensor.

Signed-off-by: Tomasz Duszynski <tduszyns@gmail.com>
---
 .../bindings/iio/chemical/plantower,pms7003.txt    | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/iio/chemical/plantower,pms7003.txt

Comments

Rob Herring Jan. 11, 2019, 10:15 p.m. UTC | #1
On Sun, Jan 06, 2019 at 06:16:14PM +0100, Tomasz Duszynski wrote:
> Add device tree support for Plantower PMS7003 particulate matter sensor.
> 
> Signed-off-by: Tomasz Duszynski <tduszyns@gmail.com>
> ---
>  .../bindings/iio/chemical/plantower,pms7003.txt    | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/chemical/plantower,pms7003.txt
> 
> diff --git a/Documentation/devicetree/bindings/iio/chemical/plantower,pms7003.txt b/Documentation/devicetree/bindings/iio/chemical/plantower,pms7003.txt
> new file mode 100644
> index 000000000000..79eb538eb932
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/chemical/plantower,pms7003.txt
> @@ -0,0 +1,14 @@
> +* Plantower PMS7003 particulate matter sensor
> +
> +Required properties:
> +- compatible: must be "plantower,pms7003"

Looks like this has reset and set GPIO lines as well as Vcc supply. 
Bindings should be complete even if the driver or a platform doesn't use 
some parts.

> +
> +Refer to serial/slave-device.txt for generic serial attached device bindings.
> +
> +Example:
> +
> +&uart@0 {
> +	pms7003 {
> +		compatible = "plantower,pms7003";
> +	};
> +};
> -- 
> 2.20.1
>
Tomasz Duszynski Jan. 27, 2019, 1:45 p.m. UTC | #2
On Fri, Jan 11, 2019 at 04:15:26PM -0600, Rob Herring wrote:
> On Sun, Jan 06, 2019 at 06:16:14PM +0100, Tomasz Duszynski wrote:
> > Add device tree support for Plantower PMS7003 particulate matter sensor.
> >
> > Signed-off-by: Tomasz Duszynski <tduszyns@gmail.com>
> > ---
> >  .../bindings/iio/chemical/plantower,pms7003.txt    | 14 ++++++++++++++
> >  1 file changed, 14 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/iio/chemical/plantower,pms7003.txt
> >
> > diff --git a/Documentation/devicetree/bindings/iio/chemical/plantower,pms7003.txt b/Documentation/devicetree/bindings/iio/chemical/plantower,pms7003.txt
> > new file mode 100644
> > index 000000000000..79eb538eb932
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/iio/chemical/plantower,pms7003.txt
> > @@ -0,0 +1,14 @@
> > +* Plantower PMS7003 particulate matter sensor
> > +
> > +Required properties:
> > +- compatible: must be "plantower,pms7003"
>
> Looks like this has reset and set GPIO lines as well as Vcc supply.
> Bindings should be complete even if the driver or a platform doesn't use
> some parts.
>

Fine. I'll add missing pin descriptions in v2 then.

> > +
> > +Refer to serial/slave-device.txt for generic serial attached device bindings.
> > +
> > +Example:
> > +
> > +&uart@0 {
> > +	pms7003 {
> > +		compatible = "plantower,pms7003";
> > +	};
> > +};
> > --
> > 2.20.1
> >

Patch
diff mbox series

diff --git a/Documentation/devicetree/bindings/iio/chemical/plantower,pms7003.txt b/Documentation/devicetree/bindings/iio/chemical/plantower,pms7003.txt
new file mode 100644
index 000000000000..79eb538eb932
--- /dev/null
+++ b/Documentation/devicetree/bindings/iio/chemical/plantower,pms7003.txt
@@ -0,0 +1,14 @@ 
+* Plantower PMS7003 particulate matter sensor
+
+Required properties:
+- compatible: must be "plantower,pms7003"
+
+Refer to serial/slave-device.txt for generic serial attached device bindings.
+
+Example:
+
+&uart@0 {
+	pms7003 {
+		compatible = "plantower,pms7003";
+	};
+};