From: Bo YU <tsu.yubo@gmail.com>
To: gregkh@linuxfoundation.org, rafael@kernel.org
Cc: Bo YU <tsu.yubo@gmail.com>,
linux-kernel@vger.kernel.org, joe@perches.com, yuzibode@126.com
Subject: [PATCH v4 2/2] kobject: drop newline from msg string
Date: Mon, 7 Jan 2019 22:11:35 -0500 [thread overview]
Message-ID: <2ba5177197f8b40e399867ea1f1aee2920c3cb49.1546915794.git.tsu.yubo@gmail.com> (raw)
In-Reply-To: <cover.1546915794.git.tsu.yubo@gmail.com>
There is currently a missing terminating newline in non-switch case
match,when msg == NULL
Signed-off-by: Bo YU <tsu.yubo@gmail.com>
---
Changes in V4:
Recovery originly declaration, requested by Greg.
Changes in V3:
Improve the commit log, requested by rafael.
Changes in V2:
According to Joe's suggestion, drop newline from msg string
---
lib/kobject_uevent.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/lib/kobject_uevent.c b/lib/kobject_uevent.c
index 499dfcdafcb0..118226a02707 100644
--- a/lib/kobject_uevent.c
+++ b/lib/kobject_uevent.c
@@ -200,7 +200,7 @@ int kobject_synth_uevent(struct kobject *kobj, const char *buf, size_t count)
r = kobject_action_type(buf, count, &action, &action_args);
if (r) {
- msg = "unknown uevent action string\n";
+ msg = "unknown uevent action string";
goto out;
}
@@ -212,7 +212,7 @@ int kobject_synth_uevent(struct kobject *kobj, const char *buf, size_t count)
r = kobject_action_args(action_args,
count - (action_args - buf), &env);
if (r == -EINVAL) {
- msg = "incorrect uevent action arguments\n";
+ msg = "incorrect uevent action arguments";
goto out;
}
@@ -224,7 +224,7 @@ int kobject_synth_uevent(struct kobject *kobj, const char *buf, size_t count)
out:
if (r) {
devpath = kobject_get_path(kobj, GFP_KERNEL);
- pr_warn("synth uevent: %s: %s",
+ pr_warn("synth uevent: %s: %s\n",
devpath ?: "unknown device",
msg ?: "failed to send uevent");
kfree(devpath);
--
2.11.0
next prev parent reply other threads:[~2019-01-08 3:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-08 3:10 [PATCH v4 0/2] kobject: trival fix Bo YU
2019-01-08 3:10 ` [PATCH v4 1/2] kobject: use pr_warn to replace printk Bo YU
2019-01-08 9:39 ` Rafael J. Wysocki
2019-01-08 12:53 ` YU Bo
2019-01-08 18:12 ` Rafael J. Wysocki
2019-01-08 3:11 ` Bo YU [this message]
2019-01-08 9:41 ` [PATCH v4 2/2] kobject: drop newline from msg string Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ba5177197f8b40e399867ea1f1aee2920c3cb49.1546915794.git.tsu.yubo@gmail.com \
--to=tsu.yubo@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=yuzibode@126.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).