From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Sekhar Nori <nsekhar@ti.com>, Kevin Hilman <khilman@kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org,
Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: [RESEND PATCH 10/12] ARM: davinci: mityomapl138: use nvmem notifiers
Date: Tue, 8 Jan 2019 10:15:37 +0100 [thread overview]
Message-ID: <20190108091539.16674-11-brgl@bgdev.pl> (raw)
In-Reply-To: <20190108091539.16674-1-brgl@bgdev.pl>
From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Stop using the at24_platform_data setup callback in favor of nvmem
notifiers.
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
---
arch/arm/mach-davinci/board-mityomapl138.c | 18 +++++++++++++++---
1 file changed, 15 insertions(+), 3 deletions(-)
diff --git a/arch/arm/mach-davinci/board-mityomapl138.c b/arch/arm/mach-davinci/board-mityomapl138.c
index 3286dc2457a5..ac1a1699d185 100644
--- a/arch/arm/mach-davinci/board-mityomapl138.c
+++ b/arch/arm/mach-davinci/board-mityomapl138.c
@@ -15,6 +15,8 @@
#include <linux/console.h>
#include <linux/platform_device.h>
#include <linux/mtd/partitions.h>
+#include <linux/notifier.h>
+#include <linux/nvmem-consumer.h>
#include <linux/nvmem-provider.h>
#include <linux/regulator/machine.h>
#include <linux/i2c.h>
@@ -117,10 +119,15 @@ static void mityomapl138_cpufreq_init(const char *partnum)
static void mityomapl138_cpufreq_init(const char *partnum) { }
#endif
-static void read_factory_config(struct nvmem_device *nvmem, void *context)
+static int read_factory_config(struct notifier_block *nb,
+ unsigned long event, void *data)
{
int ret;
const char *partnum = NULL;
+ struct nvmem_device *nvmem = data;
+
+ if (strcmp(nvmem_dev_name(nvmem), "1-00500") != 0)
+ return NOTIFY_DONE;
if (!IS_BUILTIN(CONFIG_NVMEM)) {
pr_warn("Factory Config not available without CONFIG_NVMEM\n");
@@ -152,8 +159,14 @@ static void read_factory_config(struct nvmem_device *nvmem, void *context)
bad_config:
/* default maximum speed is valid for all platforms */
mityomapl138_cpufreq_init(partnum);
+
+ return NOTIFY_STOP;
}
+static struct notifier_block mityomapl138_nvmem_notifier = {
+ .notifier_call = read_factory_config,
+};
+
/*
* We don't define a cell for factory config as it will be accessed from the
* board file using the nvmem notifier chain.
@@ -183,8 +196,6 @@ static struct at24_platform_data mityomapl138_fd_chip = {
.byte_len = 256,
.page_size = 8,
.flags = AT24_FLAG_READONLY | AT24_FLAG_IRUGO,
- .setup = read_factory_config,
- .context = NULL,
};
static struct davinci_i2c_platform_data mityomap_i2c_0_pdata = {
@@ -561,6 +572,7 @@ static void __init mityomapl138_init(void)
davinci_serial_init(da8xx_serial_device);
+ nvmem_register_notifier(&mityomapl138_nvmem_notifier);
nvmem_add_cell_table(&mityomapl138_nvmem_cell_table);
nvmem_add_cell_lookups(&mityomapl138_nvmem_cell_lookup, 1);
--
2.19.1
next prev parent reply other threads:[~2019-01-08 9:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-08 9:15 [RESEND PATCH 00/12] eeprom: at24: remove platform_data Bartosz Golaszewski
2019-01-08 9:15 ` [RESEND PATCH 01/12] ARM: davinci: da850-evm: remove dead MTD code Bartosz Golaszewski
2019-01-08 9:15 ` [RESEND PATCH 02/12] ARM: davinci: mityomapl138: don't read the MAC address from machine code Bartosz Golaszewski
2019-01-08 9:15 ` [RESEND PATCH 03/12] ARM: davinci: dm365-evm: use device properties for at24 eeprom Bartosz Golaszewski
2019-01-08 9:15 ` [RESEND PATCH 04/12] ARM: davinci: da830-evm: " Bartosz Golaszewski
2019-01-08 9:15 ` [RESEND PATCH 05/12] ARM: davinci: dm644x-evm: " Bartosz Golaszewski
2019-01-08 9:15 ` [RESEND PATCH 06/12] ARM: davinci: dm646x-evm: " Bartosz Golaszewski
2019-01-08 9:15 ` [RESEND PATCH 07/12] ARM: davinci: sffsdr: fix the at24 eeprom device name Bartosz Golaszewski
2019-01-08 9:15 ` [RESEND PATCH 08/12] ARM: davinci: sffsdr: use device properties for at24 eeprom Bartosz Golaszewski
2019-01-08 9:15 ` [RESEND PATCH 09/12] ARM: davinci: remove dead code related to MAC address reading Bartosz Golaszewski
2019-01-08 9:15 ` Bartosz Golaszewski [this message]
2019-01-08 9:15 ` [RESEND PATCH 11/12] ARM: davinci: mityomapl138: use device properties for at24 eeprom Bartosz Golaszewski
2019-01-08 9:15 ` [RESEND PATCH 12/12] eeprom: at24: remove at24_platform_data Bartosz Golaszewski
2019-01-10 14:13 ` [RESEND PATCH 00/12] eeprom: at24: remove platform_data Sekhar Nori
2019-01-22 12:22 ` Greg Kroah-Hartman
2019-01-27 12:26 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190108091539.16674-11-brgl@bgdev.pl \
--to=brgl@bgdev.pl \
--cc=arnd@arndb.de \
--cc=bgolaszewski@baylibre.com \
--cc=gregkh@linuxfoundation.org \
--cc=khilman@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nsekhar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).