From: Bo YU <tsu.yubo@gmail.com>
To: gregkh@linuxfoundation.org, rafael@kernel.org
Cc: Bo YU <tsu.yubo@gmail.com>,
linux-kernel@vger.kernel.org, joe@perches.com, yuzibode@126.com
Subject: [PATCH V5 1/2] kobject: to repalce printk with pr_* style
Date: Wed, 9 Jan 2019 04:17:00 -0500 [thread overview]
Message-ID: <99e9edd31414bd240286b5b63b39140fc74e6ca5.1547024167.git.tsu.yubo@gmail.com> (raw)
In-Reply-To: <cover.1547024167.git.tsu.yubo@gmail.com>
Repalce printk with pr_warn in kobject_synth_uevent and replace
printk with pr_err in uevent_net_init to make both consistent with
other code in kobject_uevent.c
Signed-off-by: Bo YU <tsu.yubo@gmail.com>
---
Changes in V2:
Improve the commit log, doing as the patch did.
---
lib/kobject_uevent.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/lib/kobject_uevent.c b/lib/kobject_uevent.c
index 27c6118afd1c..c87a96c4800e 100644
--- a/lib/kobject_uevent.c
+++ b/lib/kobject_uevent.c
@@ -224,7 +224,7 @@ int kobject_synth_uevent(struct kobject *kobj, const char *buf, size_t count)
out:
if (r) {
devpath = kobject_get_path(kobj, GFP_KERNEL);
- printk(KERN_WARNING "synth uevent: %s: %s",
+ pr_warn("synth uevent: %s: %s",
devpath ?: "unknown device",
msg ?: "failed to send uevent");
kfree(devpath);
@@ -765,8 +765,7 @@ static int uevent_net_init(struct net *net)
ue_sk->sk = netlink_kernel_create(net, NETLINK_KOBJECT_UEVENT, &cfg);
if (!ue_sk->sk) {
- printk(KERN_ERR
- "kobject_uevent: unable to create netlink socket!\n");
+ pr_err("kobject_uevent: unable to create netlink socket!\n");
kfree(ue_sk);
return -ENODEV;
}
--
2.11.0
next prev parent reply other threads:[~2019-01-09 9:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-09 9:16 [PATCH V5 0/2] kobject: fix code style and drop newline Bo YU
2019-01-09 9:17 ` Bo YU [this message]
2019-01-09 9:20 ` [PATCH V5 1/2] kobject: to repalce printk with pr_* style Rafael J. Wysocki
2019-01-09 9:17 ` [PATCH V5 2/2] kobject: drop newline from msg string Bo YU
2019-01-09 9:21 ` Rafael J. Wysocki
2019-01-09 9:30 ` YU Bo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99e9edd31414bd240286b5b63b39140fc74e6ca5.1547024167.git.tsu.yubo@gmail.com \
--to=tsu.yubo@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=yuzibode@126.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).