From: Logan Gunthorpe <logang@deltatee.com>
To: linux-kernel@vger.kernel.org, linux-ntb@googlegroups.com,
Jon Mason <jdmason@kudzu.us>
Cc: Allen Hubbe <allenbh@gmail.com>,
Dave Jiang <dave.jiang@intel.com>,
Serge Semin <fancer.lancer@gmail.com>,
Logan Gunthorpe <logang@deltatee.com>
Subject: [PATCH v3 8/8] NTB: ntb_test: Fix bug when counting remote files
Date: Wed, 9 Jan 2019 12:22:33 -0700 [thread overview]
Message-ID: <20190109192233.5752-9-logang@deltatee.com> (raw)
In-Reply-To: <20190109192233.5752-1-logang@deltatee.com>
When remote files are counted in get_files_count, without using SSH,
the code returns 0 because there is a colon prepended to $LOC. $VPATH
should have been used instead of $LOC.
Fixes: 06bd0407d06c ("NTB: ntb_test: Update ntb_tool Scratchpad tests")
Signed-off-by: Logan Gunthorpe <logang@deltatee.com>
Acked-by: Allen Hubbe <allenbh@gmail.com>
Tested-by: Alexander Fomichev <fomichev.ru@gmail.com>
---
tools/testing/selftests/ntb/ntb_test.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/ntb/ntb_test.sh b/tools/testing/selftests/ntb/ntb_test.sh
index 08cbfbbc7029..17ca36403d04 100755
--- a/tools/testing/selftests/ntb/ntb_test.sh
+++ b/tools/testing/selftests/ntb/ntb_test.sh
@@ -250,7 +250,7 @@ function get_files_count()
split_remote $LOC
if [[ "$REMOTE" == "" ]]; then
- echo $(ls -1 "$LOC"/${NAME}* 2>/dev/null | wc -l)
+ echo $(ls -1 "$VPATH"/${NAME}* 2>/dev/null | wc -l)
else
echo $(ssh "$REMOTE" "ls -1 \"$VPATH\"/${NAME}* | \
wc -l" 2> /dev/null)
--
2.19.0
next prev parent reply other threads:[~2019-01-09 19:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-09 19:22 [PATCH v3 0/8] Fix breakage caused by the NTB multi-port patchset Logan Gunthorpe
2019-01-09 19:22 ` [PATCH v3 1/8] NTB: ntb_tool: reading the link file should not end in a NULL byte Logan Gunthorpe
2019-01-09 19:22 ` [PATCH v3 2/8] NTB: Revert the change to use the NTB device dev for DMA allocations Logan Gunthorpe
2019-01-09 19:22 ` [PATCH v3 3/8] NTB: Fix the default port and peer numbers for legacy drivers Logan Gunthorpe
2019-01-09 19:22 ` [PATCH v3 4/8] NTB: ntb_pingpong: Choose doorbells based on port number Logan Gunthorpe
2019-01-09 19:22 ` [PATCH v3 5/8] NTB: perf: Don't require one more memory window than number of peers Logan Gunthorpe
2019-01-09 19:22 ` [PATCH v3 6/8] NTB: perf: Fix support for hardware that doesn't have port numbers Logan Gunthorpe
2019-01-09 19:22 ` [PATCH v3 7/8] NTB: perf: Fix race condition when run with ntb_test Logan Gunthorpe
2019-01-09 19:22 ` Logan Gunthorpe [this message]
2019-01-09 19:32 ` [PATCH v3 0/8] Fix breakage caused by the NTB multi-port patchset Dave Jiang
2019-01-09 19:33 ` Logan Gunthorpe
2019-02-11 14:40 ` Jon Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190109192233.5752-9-logang@deltatee.com \
--to=logang@deltatee.com \
--cc=allenbh@gmail.com \
--cc=dave.jiang@intel.com \
--cc=fancer.lancer@gmail.com \
--cc=jdmason@kudzu.us \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ntb@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).