From: Vineet Gupta <vineet.gupta1@synopsys.com>
To: <linux-kernel@vger.kernel.org>
Cc: <linux-snps-arc@lists.infradead.org>, <linux-mm@kvack.org>,
<peterz@infradead.org>, Vineet Gupta <vineet.gupta1@synopsys.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Theodore Ts'o <tytso@mit.edu>, <linux-fsdevel@vger.kernel.org>
Subject: [PATCH 2/3] fs: inode_set_flags() replace opencoded set_mask_bits()
Date: Thu, 10 Jan 2019 16:26:26 -0800 [thread overview]
Message-ID: <1547166387-19785-3-git-send-email-vgupta@synopsys.com> (raw)
In-Reply-To: <1547166387-19785-1-git-send-email-vgupta@synopsys.com>
It seems that 5f16f3225b0624 and 00a1a053ebe5, both with same commitlog
("ext4: atomically set inode->i_flags in ext4_set_inode_flags()")
introduced the set_mask_bits API, but somehow missed not using it in
ext4 in the end
Also, set_mask_bits is used in fs quite a bit and we can possibly come up
with a generic llsc based implementation (w/o the cmpxchg loop)
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: Theodore Ts'o <tytso@mit.edu>
Cc: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: linux-fsdevel@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Vineet Gupta <vgupta@synopsys.com>
---
fs/inode.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/fs/inode.c b/fs/inode.c
index 0cd47fe0dbe5..799b0c4beda8 100644
--- a/fs/inode.c
+++ b/fs/inode.c
@@ -2096,14 +2096,8 @@ EXPORT_SYMBOL(inode_dio_wait);
void inode_set_flags(struct inode *inode, unsigned int flags,
unsigned int mask)
{
- unsigned int old_flags, new_flags;
-
WARN_ON_ONCE(flags & ~mask);
- do {
- old_flags = READ_ONCE(inode->i_flags);
- new_flags = (old_flags & ~mask) | flags;
- } while (unlikely(cmpxchg(&inode->i_flags, old_flags,
- new_flags) != old_flags));
+ set_mask_bits(&inode->i_flags, mask, flags);
}
EXPORT_SYMBOL(inode_set_flags);
--
2.7.4
next prev parent reply other threads:[~2019-01-11 0:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-11 0:26 [PATCH 0/3] Replace opencoded set_mask_bits Vineet Gupta
2019-01-11 0:26 ` [PATCH 1/3] coredump: Replace opencoded set_mask_bits() Vineet Gupta
2019-01-11 4:24 ` Anthony Yznaga
2019-01-11 0:26 ` Vineet Gupta [this message]
2019-01-11 4:24 ` [PATCH 2/3] fs: inode_set_flags() replace " Anthony Yznaga
2019-01-11 0:26 ` [PATCH 3/3] bitops.h: set_mask_bits() to return old value Vineet Gupta
2019-01-11 4:25 ` Anthony Yznaga
2019-01-11 9:24 ` Peter Zijlstra
2019-01-11 20:58 ` Vineet Gupta
2019-01-14 19:00 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1547166387-19785-3-git-send-email-vgupta@synopsys.com \
--to=vineet.gupta1@synopsys.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=peterz@infradead.org \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).