From: Vineet Gupta <vineet.gupta1@synopsys.com>
To: <linux-kernel@vger.kernel.org>
Cc: <linux-snps-arc@lists.infradead.org>, <linux-mm@kvack.org>,
<peterz@infradead.org>, Vineet Gupta <vineet.gupta1@synopsys.com>,
Miklos Szeredi <mszeredi@redhat.com>,
Ingo Molnar <mingo@kernel.org>,
Jani Nikula <jani.nikula@intel.com>,
Chris Wilson <chris@chris-wilson.co.uk>,
"Andrew Morton" <akpm@linux-foundation.org>,
Will Deacon <will.deacon@arm.com>
Subject: [PATCH 3/3] bitops.h: set_mask_bits() to return old value
Date: Thu, 10 Jan 2019 16:26:27 -0800 [thread overview]
Message-ID: <1547166387-19785-4-git-send-email-vgupta@synopsys.com> (raw)
In-Reply-To: <1547166387-19785-1-git-send-email-vgupta@synopsys.com>
| > Also, set_mask_bits is used in fs quite a bit and we can possibly come up
| > with a generic llsc based implementation (w/o the cmpxchg loop)
|
| May I also suggest changing the return value of set_mask_bits() to old.
|
| You can compute the new value given old, but you cannot compute the old
| value given new, therefore old is the better return value. Also, no
| current user seems to use the return value, so changing it is without
| risk.
Link: http://lkml.kernel.org/g/20150807110955.GH16853@twins.programming.kicks-ass.net
Suggested-by: Peter Zijlstra <peterz@infradead.org>
Cc: Miklos Szeredi <mszeredi@redhat.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Will Deacon <will.deacon@arm.com>
Signed-off-by: Vineet Gupta <vgupta@synopsys.com>
---
include/linux/bitops.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/bitops.h b/include/linux/bitops.h
index 705f7c442691..602af23b98c7 100644
--- a/include/linux/bitops.h
+++ b/include/linux/bitops.h
@@ -246,7 +246,7 @@ static __always_inline void __assign_bit(long nr, volatile unsigned long *addr,
new__ = (old__ & ~mask__) | bits__; \
} while (cmpxchg(ptr, old__, new__) != old__); \
\
- new__; \
+ old__; \
})
#endif
--
2.7.4
next prev parent reply other threads:[~2019-01-11 0:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-11 0:26 [PATCH 0/3] Replace opencoded set_mask_bits Vineet Gupta
2019-01-11 0:26 ` [PATCH 1/3] coredump: Replace opencoded set_mask_bits() Vineet Gupta
2019-01-11 4:24 ` Anthony Yznaga
2019-01-11 0:26 ` [PATCH 2/3] fs: inode_set_flags() replace " Vineet Gupta
2019-01-11 4:24 ` Anthony Yznaga
2019-01-11 0:26 ` Vineet Gupta [this message]
2019-01-11 4:25 ` [PATCH 3/3] bitops.h: set_mask_bits() to return old value Anthony Yznaga
2019-01-11 9:24 ` Peter Zijlstra
2019-01-11 20:58 ` Vineet Gupta
2019-01-14 19:00 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1547166387-19785-4-git-send-email-vgupta@synopsys.com \
--to=vineet.gupta1@synopsys.com \
--cc=akpm@linux-foundation.org \
--cc=chris@chris-wilson.co.uk \
--cc=jani.nikula@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=mingo@kernel.org \
--cc=mszeredi@redhat.com \
--cc=peterz@infradead.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).