From: Kairui Song <kasong@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
hpa@zytor.com, x86@kernel.org, dyoung@redhat.com, bhe@redhat.com,
kexec@lists.infradead.org, akpm@linux-foundation.org,
robert.moore@intel.com, erik.schmauss@intel.com,
rafael.j.wysocki@intel.com, lenb@kernel.org,
Kairui Song <kasong@redhat.com>
Subject: [PATCH v2 1/2] x86, kexec_file_load: Don't setup EFI info if EFI runtime is not enabled
Date: Tue, 15 Jan 2019 17:58:33 +0800 [thread overview]
Message-ID: <20190115095834.22617-2-kasong@redhat.com> (raw)
In-Reply-To: <20190115095834.22617-1-kasong@redhat.com>
Currently with "efi=noruntime" in kernel command line, calling
kexec_file_load will raise below problem:
[ 97.967067] BUG: unable to handle kernel NULL pointer dereference at 0000000000000000
[ 97.967894] #PF error: [normal kernel read fault]
...
[ 97.980456] Call Trace:
[ 97.980724] efi_runtime_map_copy+0x28/0x30
[ 97.981267] bzImage64_load+0x688/0x872
[ 97.981794] arch_kexec_kernel_image_load+0x6d/0x70
[ 97.982441] kimage_file_alloc_init+0x13e/0x220
[ 97.983035] __x64_sys_kexec_file_load+0x144/0x290
[ 97.983586] do_syscall_64+0x55/0x1a0
[ 97.983962] entry_SYSCALL_64_after_hwframe+0x44/0xa9
When efi runtime is not enabled, efi memmap is not mapped, so just skip
EFI info setup.
Suggested-by: Dave Young <dyoung@redhat.com>
Signed-off-by: Kairui Song <kasong@redhat.com>
---
arch/x86/kernel/kexec-bzimage64.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/x86/kernel/kexec-bzimage64.c b/arch/x86/kernel/kexec-bzimage64.c
index 0d5efa34f359..53917a3ebf94 100644
--- a/arch/x86/kernel/kexec-bzimage64.c
+++ b/arch/x86/kernel/kexec-bzimage64.c
@@ -167,6 +167,9 @@ setup_efi_state(struct boot_params *params, unsigned long params_load_addr,
struct efi_info *current_ei = &boot_params.efi_info;
struct efi_info *ei = ¶ms->efi_info;
+ if (!efi_enabled(EFI_RUNTIME_SERVICES))
+ return 0;
+
if (!current_ei->efi_memmap_size)
return 0;
--
2.20.1
next prev parent reply other threads:[~2019-01-15 9:59 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-15 9:58 [PATCH 0/2] make kexec work with efi=noruntime or efi=old_map Kairui Song
2019-01-15 9:58 ` Kairui Song [this message]
2019-01-15 9:58 ` [PATCH v2 2/2] x86, kexec_file_load: make it " Kairui Song
2019-01-15 23:10 ` Borislav Petkov
2019-01-16 3:32 ` Dave Young
2019-01-16 5:09 ` Kairui Song
2019-01-16 6:51 ` Dave Young
2019-01-16 22:24 ` Rafael J. Wysocki
2019-01-16 7:08 ` Kairui Song
2019-01-16 9:46 ` Borislav Petkov
2019-01-17 7:41 ` Kairui Song
2019-01-17 7:49 ` Chao Fan
2019-01-17 8:20 ` Kairui Song
2019-01-17 8:54 ` Dave Young
2019-01-17 8:53 ` Dave Young
2019-01-17 9:39 ` Rafael J. Wysocki
2019-01-18 4:47 ` Kairui Song
2019-01-18 9:45 ` Rafael J. Wysocki
2019-01-18 10:26 ` Borislav Petkov
2019-01-21 1:18 ` Chao Fan
2019-01-21 8:29 ` Borislav Petkov
2019-01-21 8:43 ` Chao Fan
2019-01-21 9:19 ` Borislav Petkov
2019-01-22 3:32 ` Chao Fan
2019-01-22 12:17 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190115095834.22617-2-kasong@redhat.com \
--to=kasong@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=bp@alien8.de \
--cc=dyoung@redhat.com \
--cc=erik.schmauss@intel.com \
--cc=hpa@zytor.com \
--cc=kexec@lists.infradead.org \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rafael.j.wysocki@intel.com \
--cc=robert.moore@intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).