From: Mathieu Malaterre <malat@debian.org>
To: Daniel Borkmann <daniel@iogearbox.net>
Cc: Mathieu Malaterre <malat@debian.org>,
Alexei Starovoitov <ast@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2 1/2] bpf: Annotate implicit fall through in cgroup_dev_func_proto
Date: Wed, 16 Jan 2019 20:35:29 +0100 [thread overview]
Message-ID: <20190116193529.32488-1-malat@debian.org> (raw)
In-Reply-To: <20190114202941.16183-1-malat@debian.org>
There is a plan to build the kernel with -Wimplicit-fallthrough and
this place in the code produced a warnings (W=1).
This commit remove the following warning:
kernel/bpf/cgroup.c:719:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
Signed-off-by: Mathieu Malaterre <malat@debian.org>
---
v2: Reword the patch subject
kernel/bpf/cgroup.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/kernel/bpf/cgroup.c b/kernel/bpf/cgroup.c
index 9425c2fb872f..ab612fe9862f 100644
--- a/kernel/bpf/cgroup.c
+++ b/kernel/bpf/cgroup.c
@@ -718,6 +718,7 @@ cgroup_dev_func_proto(enum bpf_func_id func_id, const struct bpf_prog *prog)
case BPF_FUNC_trace_printk:
if (capable(CAP_SYS_ADMIN))
return bpf_get_trace_printk_proto();
+ /* fall through */
default:
return NULL;
}
--
2.19.2
next prev parent reply other threads:[~2019-01-16 19:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-14 20:29 [PATCH 1/2] bpf: annotate implicit fall through Mathieu Malaterre
2019-01-14 20:29 ` [PATCH 2/2] " Mathieu Malaterre
2019-01-15 9:03 ` Sergei Shtylyov
2019-01-15 20:01 ` Daniel Borkmann
2019-01-16 19:35 ` [PATCH v2 2/2] bpf: Correctly annotate implicit fall through in bpf_base_func_proto Mathieu Malaterre
2019-01-16 19:32 ` [PATCH v2 1/2] bpf: Annotate implicit fall through in cgroup_dev_func_proto Mathieu Malaterre
2019-01-16 19:35 ` Mathieu Malaterre [this message]
2019-01-17 15:57 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190116193529.32488-1-malat@debian.org \
--to=malat@debian.org \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).