From: Andreas Kemnade <andreas@kemnade.info>
To: t-kristo@ti.com, mturquette@baylibre.com, sboyd@kernel.org,
linux-omap@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org, bcousson@baylibre.com,
paul@pwsan.com, tony@atomide.com, letux-kernel@openphoenux.org
Cc: Andreas Kemnade <andreas@kemnade.info>
Subject: [PATCH v3 2/3] clk: ti: check clock type before doing autoidle ops
Date: Wed, 16 Jan 2019 23:04:28 +0100 [thread overview]
Message-ID: <20190116220429.9136-3-andreas@kemnade.info> (raw)
In-Reply-To: <20190116220429.9136-1-andreas@kemnade.info>
Code might use autoidle api with clocks not being omap2 clocks,
so check if clock type is really omap2.
Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
---
v3: replace CLK_IS_BASIC check
New in v2
drivers/clk/ti/autoidle.c | 20 ++++++++++++++++----
1 file changed, 16 insertions(+), 4 deletions(-)
diff --git a/drivers/clk/ti/autoidle.c b/drivers/clk/ti/autoidle.c
index 964e97b5478a..1cae226759dd 100644
--- a/drivers/clk/ti/autoidle.c
+++ b/drivers/clk/ti/autoidle.c
@@ -82,9 +82,15 @@ static int _omap2_clk_allow_idle(struct clk_hw_omap *clk)
*/
int omap2_clk_deny_idle(struct clk *clk)
{
- struct clk_hw_omap *c = to_clk_hw_omap(__clk_get_hw(clk));
+ struct clk_hw *hw = __clk_get_hw(clk);
- return _omap2_clk_deny_idle(c);
+ if (omap2_clk_is_hw_omap(hw)) {
+ struct clk_hw_omap *c = to_clk_hw_omap(hw);
+
+ return _omap2_clk_deny_idle(c);
+ }
+
+ return -EINVAL;
}
/**
@@ -95,9 +101,15 @@ int omap2_clk_deny_idle(struct clk *clk)
*/
int omap2_clk_allow_idle(struct clk *clk)
{
- struct clk_hw_omap *c = to_clk_hw_omap(__clk_get_hw(clk));
+ struct clk_hw *hw = __clk_get_hw(clk);
+
+ if (omap2_clk_is_hw_omap(hw)) {
+ struct clk_hw_omap *c = to_clk_hw_omap(hw);
+
+ return _omap2_clk_allow_idle(c);
+ }
- return _omap2_clk_allow_idle(c);
+ return -EINVAL;
}
static void _allow_autoidle(struct clk_ti_autoidle *clk)
--
2.11.0
next prev parent reply other threads:[~2019-01-16 22:04 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-16 22:04 [PATCH v3 0/3] mach-omap2: handle autoidle denial Andreas Kemnade
2019-01-16 22:04 ` [PATCH v3 1/3] clk: ti: add a usecount for autoidle Andreas Kemnade
2019-01-16 22:04 ` Andreas Kemnade [this message]
2019-01-16 22:04 ` [PATCH v3 3/3] arm: omap_hwmod disable ick autoidling when a hwmod requires that Andreas Kemnade
2019-01-18 15:48 ` Tony Lindgren
2019-01-18 17:18 ` Andreas Kemnade
2019-01-18 18:36 ` Tony Lindgren
2019-01-18 19:38 ` Andreas Kemnade
2019-01-18 19:42 ` [Letux-kernel] " Andreas Kemnade
2019-01-18 19:48 ` Tony Lindgren
2019-01-19 6:39 ` J, KEERTHY
2019-01-19 7:12 ` Andreas Kemnade
2019-01-19 7:58 ` J, KEERTHY
2019-01-22 6:26 ` Keerthy
2019-01-18 19:45 ` Tony Lindgren
2019-01-21 7:12 ` Tero Kristo
2019-01-21 17:07 ` Tony Lindgren
2019-01-21 17:53 ` Andreas Kemnade
2019-01-21 19:56 ` Tony Lindgren
2019-01-21 19:58 ` [PATCH v3 0/3] mach-omap2: handle autoidle denial Tony Lindgren
2019-02-09 18:53 ` Andreas Kemnade
2019-02-15 19:19 ` Tero Kristo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190116220429.9136-3-andreas@kemnade.info \
--to=andreas@kemnade.info \
--cc=bcousson@baylibre.com \
--cc=letux-kernel@openphoenux.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=paul@pwsan.com \
--cc=sboyd@kernel.org \
--cc=t-kristo@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).