From: Masami Hiramatsu <mhiramat@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Andreas Ziegler <andreas.ziegler@fau.de>,
Masami Hiramatsu <mhiramat@kernel.org>,
Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH v2 2/3] tracing: probeevent: Do not accumulate on ret variable
Date: Fri, 18 Jan 2019 13:44:54 +0900 [thread overview]
Message-ID: <154778669389.19927.8802462599466946288.stgit@devbox> (raw)
In-Reply-To: <154778663676.19927.12774448308165809570.stgit@devbox>
Do not accumulate strlen result on "ret" local variable, because
it is accumulated on "total" local variable for array case.
Fixes: 40b53b771806 ("tracing: probeevent: Add array type support")
Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
---
kernel/trace/trace_probe_tmpl.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/trace/trace_probe_tmpl.h b/kernel/trace/trace_probe_tmpl.h
index 5c56afc17cf8..e69b05a9f57c 100644
--- a/kernel/trace/trace_probe_tmpl.h
+++ b/kernel/trace/trace_probe_tmpl.h
@@ -88,7 +88,7 @@ process_fetch_insn_bottom(struct fetch_insn *code, unsigned long val,
/* 3rd stage: store value to buffer */
if (unlikely(!dest)) {
if (code->op == FETCH_OP_ST_STRING) {
- ret += fetch_store_strlen(val + code->offset);
+ ret = fetch_store_strlen(val + code->offset);
code++;
goto array;
} else
next prev parent reply other threads:[~2019-01-18 4:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-18 4:43 [PATCH v2 0/3] tracing: probeevent: Fix probe argument parser and handler Masami Hiramatsu
2019-01-18 4:44 ` [PATCH v2 1/3] tracing: uprobes: Re-enable $comm support for uprobe events Masami Hiramatsu
2019-01-23 8:40 ` Steven Rostedt
2019-01-24 1:43 ` Masami Hiramatsu
2019-01-24 2:09 ` Steven Rostedt
2019-01-24 3:03 ` Masami Hiramatsu
2019-02-06 20:52 ` Steven Rostedt
2019-02-08 0:42 ` Masami Hiramatsu
2019-01-18 4:44 ` Masami Hiramatsu [this message]
2019-01-18 4:45 ` [PATCH v2 3/3] tracing: probeevent: Fix to make the type of $comm string Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=154778669389.19927.8802462599466946288.stgit@devbox \
--to=mhiramat@kernel.org \
--cc=andreas.ziegler@fau.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).