linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Agner <stefan@agner.ch>
To: timur@kernel.org, nicoleotsuka@gmail.com, Xiubo.Lee@gmail.com
Cc: fabio.estevam@nxp.com, lgirdwood@gmail.com, broonie@kernel.org,
	perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org,
	linux-kernel@vger.kernel.org, Stefan Agner <stefan@agner.ch>,
	Daniel Baluta <daniel.baluta@nxp.com>
Subject: [PATCH v2 5/5] ASoC: imx-spdif: don't print EPROBE_DEFER as error
Date: Fri, 18 Jan 2019 10:06:56 +0100	[thread overview]
Message-ID: <20190118090656.14201-5-stefan@agner.ch> (raw)
In-Reply-To: <20190118090656.14201-1-stefan@agner.ch>

Probe deferral is to be expected during normal operation, so avoid
printing an error when it is encountered.

Removing the goto would not be strictly necessary. However, if
code gets added later, the cleanup in the EPROBE_DEFER case likely
would get missed.

Signed-off-by: Stefan Agner <stefan@agner.ch>
Reviewed-by: Daniel Baluta <daniel.baluta@nxp.com>
Acked-by: Nicolin Chen <nicoleotsuka@gmail.com>
---
 sound/soc/fsl/imx-spdif.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/sound/soc/fsl/imx-spdif.c b/sound/soc/fsl/imx-spdif.c
index fb896b2c9ba3..797d66e43d49 100644
--- a/sound/soc/fsl/imx-spdif.c
+++ b/sound/soc/fsl/imx-spdif.c
@@ -67,10 +67,8 @@ static int imx_spdif_audio_probe(struct platform_device *pdev)
 		goto end;
 
 	ret = devm_snd_soc_register_card(&pdev->dev, &data->card);
-	if (ret) {
+	if (ret && ret != -EPROBE_DEFER)
 		dev_err(&pdev->dev, "snd_soc_register_card failed: %d\n", ret);
-		goto end;
-	}
 
 end:
 	of_node_put(spdif_np);
-- 
2.20.1


  parent reply	other threads:[~2019-01-18  9:07 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-18  9:06 [PATCH v2 1/5] ASoC: imx-sgtl5000: put of nodes if finding codec fails Stefan Agner
2019-01-18  9:06 ` [PATCH v2 2/5] ASoC: imx-sgtl5000: lower log level for potential probe deferral cases Stefan Agner
2019-01-18 10:41   ` [alsa-devel] " Fabio Estevam
2019-01-18  9:06 ` [PATCH v2 3/5] ASoC: imx-sgtl5000: don't print EPROBE_DEFER as error Stefan Agner
2019-01-18 10:42   ` [alsa-devel] " Fabio Estevam
2019-01-18  9:06 ` [PATCH v2 4/5] ASoC: fsl_spdif: " Stefan Agner
2019-01-18 10:42   ` [alsa-devel] " Fabio Estevam
2019-01-18  9:06 ` Stefan Agner [this message]
2019-01-18 10:43   ` [alsa-devel] [PATCH v2 5/5] ASoC: imx-spdif: " Fabio Estevam
2019-01-18 10:41 ` [alsa-devel] [PATCH v2 1/5] ASoC: imx-sgtl5000: put of nodes if finding codec fails Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190118090656.14201-5-stefan@agner.ch \
    --to=stefan@agner.ch \
    --cc=Xiubo.Lee@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=daniel.baluta@nxp.com \
    --cc=fabio.estevam@nxp.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nicoleotsuka@gmail.com \
    --cc=perex@perex.cz \
    --cc=timur@kernel.org \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).