From: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
To: dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com
Cc: Maxime Ripard <maxime.ripard@bootlin.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Chen-Yu Tsai <wens@csie.org>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Sean Paul <sean@poorly.run>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Subject: [PATCH RESEND v5 18/23] drm/sun4i: frontend: Add a quirk structure
Date: Fri, 18 Jan 2019 15:51:28 +0100 [thread overview]
Message-ID: <20190118145133.21281-19-paul.kocialkowski@bootlin.com> (raw)
In-Reply-To: <20190118145133.21281-1-paul.kocialkowski@bootlin.com>
From: Maxime Ripard <maxime.ripard@bootlin.com>
The ACCESS_CTRL bit is not found on all the variants of the frontend, so
let's introduce a structure that will hold whether or not we need to set
it, and associate it with the compatible.
This will be extended for further similar quirks later on.
Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
---
drivers/gpu/drm/sun4i/sun4i_frontend.c | 21 +++++++++++++++++----
drivers/gpu/drm/sun4i/sun4i_frontend.h | 6 ++++++
2 files changed, 23 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/sun4i/sun4i_frontend.c b/drivers/gpu/drm/sun4i/sun4i_frontend.c
index 88ac77518610..6636b1998a76 100644
--- a/drivers/gpu/drm/sun4i/sun4i_frontend.c
+++ b/drivers/gpu/drm/sun4i/sun4i_frontend.c
@@ -10,6 +10,7 @@
#include <linux/clk.h>
#include <linux/component.h>
#include <linux/module.h>
+#include <linux/of_device.h>
#include <linux/platform_device.h>
#include <linux/pm_runtime.h>
#include <linux/regmap.h>
@@ -75,9 +76,10 @@ static void sun4i_frontend_scaler_init(struct sun4i_frontend *frontend)
{
int i;
- regmap_write_bits(frontend->regs, SUN4I_FRONTEND_FRM_CTRL_REG,
- SUN4I_FRONTEND_FRM_CTRL_COEF_ACCESS_CTRL,
- SUN4I_FRONTEND_FRM_CTRL_COEF_ACCESS_CTRL);
+ if (frontend->data->has_coef_access_ctrl)
+ regmap_write_bits(frontend->regs, SUN4I_FRONTEND_FRM_CTRL_REG,
+ SUN4I_FRONTEND_FRM_CTRL_COEF_ACCESS_CTRL,
+ SUN4I_FRONTEND_FRM_CTRL_COEF_ACCESS_CTRL);
for (i = 0; i < 32; i++) {
regmap_write(frontend->regs, SUN4I_FRONTEND_CH0_HORZCOEF0_REG(i),
@@ -553,6 +555,10 @@ static int sun4i_frontend_bind(struct device *dev, struct device *master,
frontend->dev = dev;
frontend->node = dev->of_node;
+ frontend->data = of_device_get_match_data(dev);
+ if (!frontend->data)
+ return -ENODEV;
+
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
regs = devm_ioremap_resource(dev, res);
if (IS_ERR(regs))
@@ -665,8 +671,15 @@ static const struct dev_pm_ops sun4i_frontend_pm_ops = {
.runtime_suspend = sun4i_frontend_runtime_suspend,
};
+static const struct sun4i_frontend_data sun8i_a33_frontend = {
+ .has_coef_access_ctrl = true,
+};
+
const struct of_device_id sun4i_frontend_of_table[] = {
- { .compatible = "allwinner,sun8i-a33-display-frontend" },
+ {
+ .compatible = "allwinner,sun8i-a33-display-frontend",
+ .data = &sun8i_a33_frontend
+ },
{ }
};
EXPORT_SYMBOL(sun4i_frontend_of_table);
diff --git a/drivers/gpu/drm/sun4i/sun4i_frontend.h b/drivers/gpu/drm/sun4i/sun4i_frontend.h
index 235109199b9d..01e68bb11c98 100644
--- a/drivers/gpu/drm/sun4i/sun4i_frontend.h
+++ b/drivers/gpu/drm/sun4i/sun4i_frontend.h
@@ -112,6 +112,10 @@ struct drm_plane;
struct regmap;
struct reset_control;
+struct sun4i_frontend_data {
+ bool has_coef_access_ctrl;
+};
+
struct sun4i_frontend {
struct list_head list;
struct device *dev;
@@ -122,6 +126,8 @@ struct sun4i_frontend {
struct clk *ram_clk;
struct regmap *regs;
struct reset_control *reset;
+
+ const struct sun4i_frontend_data *data;
};
extern const struct of_device_id sun4i_frontend_of_table[];
--
2.20.1
next prev parent reply other threads:[~2019-01-18 14:52 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-18 14:51 [PATCH RESEND v5 00/23] drm/sun4i: Support for linear and tiled YUV formats with the frontend Paul Kocialkowski
2019-01-18 14:51 ` [PATCH RESEND v5 01/23] drm/fourcc: Add format info helpers for checking YUV planes disposition Paul Kocialkowski
2019-01-18 14:51 ` [PATCH RESEND v5 02/23] drm/fourcc: Add format info helpers for checking YUV sub-sampling Paul Kocialkowski
2019-01-18 14:51 ` [PATCH RESEND v5 03/23] drm/sun4i: backend: Use explicit fourcc helpers for packed YUV422 check Paul Kocialkowski
2019-01-18 14:51 ` [PATCH RESEND v5 04/23] drm/sun4i: frontend: Pass DRM format info to input format helpers Paul Kocialkowski
2019-01-18 14:51 ` [PATCH RESEND v5 05/23] drm/sun4i: frontend: Determine input format based on colorspace Paul Kocialkowski
2019-01-18 14:51 ` [PATCH RESEND v5 06/23] drm/sun4i: Move the BT.601 CSC coefficients to the frontend Paul Kocialkowski
2019-01-18 14:51 ` [PATCH RESEND v5 07/23] drm/sun4i: frontend: Configure and enable YUV to RGB CSC when needed Paul Kocialkowski
2019-01-18 14:51 ` [PATCH RESEND v5 08/23] drm/sun4i: frontend: Add support for packed YUV422 input formats Paul Kocialkowski
2019-01-18 14:51 ` [PATCH RESEND v5 09/23] drm/sun4i: frontend: Add support for semi-planar YUV " Paul Kocialkowski
2019-01-18 14:51 ` [PATCH RESEND v5 10/23] drm/sun4i: frontend: Add support for planar " Paul Kocialkowski
2019-01-18 14:51 ` [PATCH RESEND v5 11/23] drm/fourcc: Add definitions for Allwinner vendor and VPU tiled format Paul Kocialkowski
2019-01-18 14:51 ` [PATCH RESEND v5 12/23] drm/sun4i: frontend: Add support for tiled YUV input mode configuration Paul Kocialkowski
2019-01-18 14:51 ` [PATCH RESEND v5 13/23] drm/sun4i: Add buffer stride and offset configuration for tiling mode Paul Kocialkowski
2019-01-18 14:51 ` [PATCH RESEND v5 14/23] drm/sun4i: frontend: Add and use helper for checking tiling support Paul Kocialkowski
2019-01-18 14:51 ` [PATCH RESEND v5 15/23] drm/sun4i: layer: Add tiled modifier support and helper Paul Kocialkowski
2019-01-18 14:51 ` [PATCH RESEND v5 16/23] drm/sun4i: drv: Allow framebuffer modifiers in mode config Paul Kocialkowski
2019-01-18 14:51 ` [PATCH RESEND v5 17/23] drm/sun4i: Move access control before setting the register as documented Paul Kocialkowski
2019-01-18 14:51 ` Paul Kocialkowski [this message]
2019-01-18 14:51 ` [PATCH RESEND v5 19/23] drm/sun4i: Set the coef_rdy bit right after the coef have been set Paul Kocialkowski
2019-01-18 14:51 ` [PATCH RESEND v5 20/23] drm/sun4i: Make COEF_RDY conditional Paul Kocialkowski
2019-01-18 14:51 ` [PATCH RESEND v5 21/23] drm/sun4i: frontend: Move the FIR filter phases to our quirks Paul Kocialkowski
2019-01-18 14:51 ` [PATCH RESEND v5 22/23] drm/sun4i: frontend: Hook-in support for the A10, with specific quirks Paul Kocialkowski
2019-01-18 14:51 ` [PATCH RESEND v5 23/23] drm/sun4i: frontend: Hook-in support for the A20 Paul Kocialkowski
2019-01-18 18:20 ` [PATCH RESEND v5 00/23] drm/sun4i: Support for linear and tiled YUV formats with the frontend Maxime Ripard
2019-01-22 10:09 ` Paul Kocialkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190118145133.21281-19-paul.kocialkowski@bootlin.com \
--to=paul.kocialkowski@bootlin.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=maxime.ripard@bootlin.com \
--cc=sean@poorly.run \
--cc=thomas.petazzoni@bootlin.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).