From: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
To: dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com
Cc: Maxime Ripard <maxime.ripard@bootlin.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Chen-Yu Tsai <wens@csie.org>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Sean Paul <sean@poorly.run>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Subject: [PATCH RESEND v5 15/23] drm/sun4i: layer: Add tiled modifier support and helper
Date: Fri, 18 Jan 2019 15:51:25 +0100 [thread overview]
Message-ID: <20190118145133.21281-16-paul.kocialkowski@bootlin.com> (raw)
In-Reply-To: <20190118145133.21281-1-paul.kocialkowski@bootlin.com>
This introduces a list of supported modifiers for the driver, that
includes the Allwinner tiled modifier, as well as a format_mod_supported
callback.
The callback uses both the backend and frontend helpers to indicate
per-format modifier support (including for the linear modifier).
Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Acked-by: Maxime Ripard <maxime.ripard@bootlin.com>
---
drivers/gpu/drm/sun4i/sun4i_layer.c | 16 +++++++++++++++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/sun4i/sun4i_layer.c b/drivers/gpu/drm/sun4i/sun4i_layer.c
index 8cf8ca997b1d..c5a999ca1d72 100644
--- a/drivers/gpu/drm/sun4i/sun4i_layer.c
+++ b/drivers/gpu/drm/sun4i/sun4i_layer.c
@@ -114,6 +114,13 @@ static void sun4i_backend_layer_atomic_update(struct drm_plane *plane,
sun4i_backend_layer_enable(backend, layer->id, true);
}
+static bool sun4i_layer_format_mod_supported(struct drm_plane *plane,
+ uint32_t format, uint64_t modifier)
+{
+ return sun4i_backend_format_is_supported(format, modifier) ||
+ sun4i_frontend_format_is_supported(format, modifier);
+}
+
static const struct drm_plane_helper_funcs sun4i_backend_layer_helper_funcs = {
.prepare_fb = drm_gem_fb_prepare_fb,
.atomic_disable = sun4i_backend_layer_atomic_disable,
@@ -127,6 +134,7 @@ static const struct drm_plane_funcs sun4i_backend_layer_funcs = {
.disable_plane = drm_atomic_helper_disable_plane,
.reset = sun4i_backend_layer_reset,
.update_plane = drm_atomic_helper_update_plane,
+ .format_mod_supported = sun4i_layer_format_mod_supported,
};
static const uint32_t sun4i_layer_formats[] = {
@@ -157,6 +165,12 @@ static const uint32_t sun4i_layer_formats[] = {
DRM_FORMAT_YVYU,
};
+static const uint64_t sun4i_layer_modifiers[] = {
+ DRM_FORMAT_MOD_LINEAR,
+ DRM_FORMAT_MOD_ALLWINNER_TILED,
+ DRM_FORMAT_MOD_INVALID
+};
+
static struct sun4i_layer *sun4i_layer_init_one(struct drm_device *drm,
struct sun4i_backend *backend,
enum drm_plane_type type)
@@ -173,7 +187,7 @@ static struct sun4i_layer *sun4i_layer_init_one(struct drm_device *drm,
&sun4i_backend_layer_funcs,
sun4i_layer_formats,
ARRAY_SIZE(sun4i_layer_formats),
- NULL, type, NULL);
+ sun4i_layer_modifiers, type, NULL);
if (ret) {
dev_err(drm->dev, "Couldn't initialize layer\n");
return ERR_PTR(ret);
--
2.20.1
next prev parent reply other threads:[~2019-01-18 14:53 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-18 14:51 [PATCH RESEND v5 00/23] drm/sun4i: Support for linear and tiled YUV formats with the frontend Paul Kocialkowski
2019-01-18 14:51 ` [PATCH RESEND v5 01/23] drm/fourcc: Add format info helpers for checking YUV planes disposition Paul Kocialkowski
2019-01-18 14:51 ` [PATCH RESEND v5 02/23] drm/fourcc: Add format info helpers for checking YUV sub-sampling Paul Kocialkowski
2019-01-18 14:51 ` [PATCH RESEND v5 03/23] drm/sun4i: backend: Use explicit fourcc helpers for packed YUV422 check Paul Kocialkowski
2019-01-18 14:51 ` [PATCH RESEND v5 04/23] drm/sun4i: frontend: Pass DRM format info to input format helpers Paul Kocialkowski
2019-01-18 14:51 ` [PATCH RESEND v5 05/23] drm/sun4i: frontend: Determine input format based on colorspace Paul Kocialkowski
2019-01-18 14:51 ` [PATCH RESEND v5 06/23] drm/sun4i: Move the BT.601 CSC coefficients to the frontend Paul Kocialkowski
2019-01-18 14:51 ` [PATCH RESEND v5 07/23] drm/sun4i: frontend: Configure and enable YUV to RGB CSC when needed Paul Kocialkowski
2019-01-18 14:51 ` [PATCH RESEND v5 08/23] drm/sun4i: frontend: Add support for packed YUV422 input formats Paul Kocialkowski
2019-01-18 14:51 ` [PATCH RESEND v5 09/23] drm/sun4i: frontend: Add support for semi-planar YUV " Paul Kocialkowski
2019-01-18 14:51 ` [PATCH RESEND v5 10/23] drm/sun4i: frontend: Add support for planar " Paul Kocialkowski
2019-01-18 14:51 ` [PATCH RESEND v5 11/23] drm/fourcc: Add definitions for Allwinner vendor and VPU tiled format Paul Kocialkowski
2019-01-18 14:51 ` [PATCH RESEND v5 12/23] drm/sun4i: frontend: Add support for tiled YUV input mode configuration Paul Kocialkowski
2019-01-18 14:51 ` [PATCH RESEND v5 13/23] drm/sun4i: Add buffer stride and offset configuration for tiling mode Paul Kocialkowski
2019-01-18 14:51 ` [PATCH RESEND v5 14/23] drm/sun4i: frontend: Add and use helper for checking tiling support Paul Kocialkowski
2019-01-18 14:51 ` Paul Kocialkowski [this message]
2019-01-18 14:51 ` [PATCH RESEND v5 16/23] drm/sun4i: drv: Allow framebuffer modifiers in mode config Paul Kocialkowski
2019-01-18 14:51 ` [PATCH RESEND v5 17/23] drm/sun4i: Move access control before setting the register as documented Paul Kocialkowski
2019-01-18 14:51 ` [PATCH RESEND v5 18/23] drm/sun4i: frontend: Add a quirk structure Paul Kocialkowski
2019-01-18 14:51 ` [PATCH RESEND v5 19/23] drm/sun4i: Set the coef_rdy bit right after the coef have been set Paul Kocialkowski
2019-01-18 14:51 ` [PATCH RESEND v5 20/23] drm/sun4i: Make COEF_RDY conditional Paul Kocialkowski
2019-01-18 14:51 ` [PATCH RESEND v5 21/23] drm/sun4i: frontend: Move the FIR filter phases to our quirks Paul Kocialkowski
2019-01-18 14:51 ` [PATCH RESEND v5 22/23] drm/sun4i: frontend: Hook-in support for the A10, with specific quirks Paul Kocialkowski
2019-01-18 14:51 ` [PATCH RESEND v5 23/23] drm/sun4i: frontend: Hook-in support for the A20 Paul Kocialkowski
2019-01-18 18:20 ` [PATCH RESEND v5 00/23] drm/sun4i: Support for linear and tiled YUV formats with the frontend Maxime Ripard
2019-01-22 10:09 ` Paul Kocialkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190118145133.21281-16-paul.kocialkowski@bootlin.com \
--to=paul.kocialkowski@bootlin.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=maxime.ripard@bootlin.com \
--cc=sean@poorly.run \
--cc=thomas.petazzoni@bootlin.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).