linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Jiri Kosina <jikos@kernel.org>,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-media@vger.kernel.org
Subject: [PATCH 1/7] Input: document meanings of KEY_SCREEN and KEY_ZOOM
Date: Fri, 18 Jan 2019 15:30:31 -0800	[thread overview]
Message-ID: <20190118233037.87318-1-dmitry.torokhov@gmail.com> (raw)

It is hard to say what KEY_SCREEN and KEY_ZOOM mean, but historically DVB
folks have used them to indicate switch to full screen mode. Later, they
converged on using KEY_ZOOM to switch into full screen mode and KEY)SCREEN
to control aspect ratio (see Documentation/media/uapi/rc/rc-tables.rst).

Let's commit to these uses, and define:

- KEY_FULL_SCREEN (and make KEY_ZOOM its alias)
- KEY_ASPECT_RATIO (and make KEY_SCREEN its alias)

Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---

Please let me know how we want merge this. Some of patches can be applied
independently and I tried marking them as such, but some require new key
names from input.h

 include/uapi/linux/input-event-codes.h | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/include/uapi/linux/input-event-codes.h b/include/uapi/linux/input-event-codes.h
index ae366b87426a..bc5054e51bef 100644
--- a/include/uapi/linux/input-event-codes.h
+++ b/include/uapi/linux/input-event-codes.h
@@ -439,10 +439,12 @@
 #define KEY_TITLE		0x171
 #define KEY_SUBTITLE		0x172
 #define KEY_ANGLE		0x173
-#define KEY_ZOOM		0x174
+#define KEY_FULL_SCREEN		0x174	/* AC View Toggle */
+#define KEY_ZOOM		KEY_FULL_SCREEN
 #define KEY_MODE		0x175
 #define KEY_KEYBOARD		0x176
-#define KEY_SCREEN		0x177
+#define KEY_ASPECT_RATIO	0x177	/* HUTRR37: Aspect */
+#define KEY_SCREEN		KEY_ASPECT_RATIO
 #define KEY_PC			0x178	/* Media Select Computer */
 #define KEY_TV			0x179	/* Media Select TV */
 #define KEY_TV2			0x17a	/* Media Select Cable */
-- 
2.20.1.321.g9e740568ce-goog


             reply	other threads:[~2019-01-18 23:30 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-18 23:30 Dmitry Torokhov [this message]
2019-01-18 23:30 ` [PATCH 2/7] [media] doc-rst: switch to new names for Full Screen/Aspect keys Dmitry Torokhov
2019-02-18  7:26   ` Dmitry Torokhov
2019-03-21 12:20     ` Mauro Carvalho Chehab
2019-01-18 23:30 ` [PATCH 3/7] HID: input: fix mapping of aspect ratio key Dmitry Torokhov
2019-01-18 23:30 ` [PATCH 4/7] HID: input: add mapping for Expose/Overview key Dmitry Torokhov
2019-01-18 23:30 ` [PATCH 5/7] HID: input: add mapping for keyboard Brightness Up/Down/Toggle keys Dmitry Torokhov
2019-01-18 23:30 ` [PATCH 6/7] HID: input: add mapping for "Full Screen" key Dmitry Torokhov
2019-01-18 23:30 ` [PATCH 7/7] HID: input: add mapping for "Toggle Display" key Dmitry Torokhov
2019-01-21 10:11 ` [PATCH 1/7] Input: document meanings of KEY_SCREEN and KEY_ZOOM Jiri Kosina
2019-01-21 10:41   ` Benjamin Tissoires
2019-01-23 22:07     ` Dmitry Torokhov
2019-03-21 12:17 ` Mauro Carvalho Chehab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190118233037.87318-1-dmitry.torokhov@gmail.com \
    --to=dmitry.torokhov@gmail.com \
    --cc=benjamin.tissoires@redhat.com \
    --cc=jikos@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).