From: Vineet Gupta <vineet.gupta1@synopsys.com>
To: <linux-kernel@vger.kernel.org>
Cc: <linux-snps-arc@lists.infradead.org>, <linux-mm@kvack.org>,
<peterz@infradead.org>, <mark.rutland@arm.com>,
Vineet Gupta <vineet.gupta1@synopsys.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
<linux-fsdevel@vger.kernel.org>
Subject: [PATCH v2 1/3] coredump: Replace opencoded set_mask_bits()
Date: Wed, 23 Jan 2019 12:33:02 -0800 [thread overview]
Message-ID: <1548275584-18096-2-git-send-email-vgupta@synopsys.com> (raw)
In-Reply-To: <1548275584-18096-1-git-send-email-vgupta@synopsys.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: linux-fsdevel@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Link: http://lkml.kernel.org/g/20150807115710.GA16897@redhat.com
Reviewed-by: Anthony Yznaga <anthony.yznaga@oracle.com>
Acked-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Vineet Gupta <vgupta@synopsys.com>
---
fs/exec.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/fs/exec.c b/fs/exec.c
index fb72d36f7823..df7f05362283 100644
--- a/fs/exec.c
+++ b/fs/exec.c
@@ -1944,15 +1944,10 @@ EXPORT_SYMBOL(set_binfmt);
*/
void set_dumpable(struct mm_struct *mm, int value)
{
- unsigned long old, new;
-
if (WARN_ON((unsigned)value > SUID_DUMP_ROOT))
return;
- do {
- old = READ_ONCE(mm->flags);
- new = (old & ~MMF_DUMPABLE_MASK) | value;
- } while (cmpxchg(&mm->flags, old, new) != old);
+ set_mask_bits(&mm->flags, MMF_DUMPABLE_MASK, value);
}
SYSCALL_DEFINE3(execve,
--
2.7.4
next prev parent reply other threads:[~2019-01-23 20:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-23 20:33 [PATCH v2 0/3] Replace opencoded set_mask_bits Vineet Gupta
2019-01-23 20:33 ` Vineet Gupta [this message]
2019-01-23 20:33 ` [PATCH v2 2/3] fs: inode_set_flags() replace opencoded set_mask_bits() Vineet Gupta
2019-01-23 20:33 ` [PATCH v2 3/3] bitops.h: set_mask_bits() to return old value Vineet Gupta
2019-02-08 18:11 ` [PATCH v2 0/3] Replace opencoded set_mask_bits Vineet Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1548275584-18096-2-git-send-email-vgupta@synopsys.com \
--to=vineet.gupta1@synopsys.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=peterz@infradead.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).