From: YueHaibing <yuehaibing@huawei.com>
To: <isdn@linux-pingi.de>, <davem@davemloft.net>,
<gustavo@embeddedor.com>, <bigeasy@linutronix.de>
Cc: <linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
YueHaibing <yuehaibing@huawei.com>
Subject: [PATCH -next] mISDN: hfcsusb: Fix potential NULL pointer dereference
Date: Wed, 30 Jan 2019 18:19:02 +0800 [thread overview]
Message-ID: <20190130101902.19744-1-yuehaibing@huawei.com> (raw)
There is a potential NULL pointer dereference in case
kzalloc() fails and returns NULL.
Fixes: 69f52adb2d53 ("mISDN: Add HFC USB driver")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/isdn/hardware/mISDN/hfcsusb.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/isdn/hardware/mISDN/hfcsusb.c b/drivers/isdn/hardware/mISDN/hfcsusb.c
index 124ff53..5660d5a 100644
--- a/drivers/isdn/hardware/mISDN/hfcsusb.c
+++ b/drivers/isdn/hardware/mISDN/hfcsusb.c
@@ -263,6 +263,8 @@ hfcsusb_ph_info(struct hfcsusb *hw)
int i;
phi = kzalloc(struct_size(phi, bch, dch->dev.nrbchan), GFP_ATOMIC);
+ if (!phi)
+ return;
phi->dch.ch.protocol = hw->protocol;
phi->dch.ch.Flags = dch->Flags;
phi->dch.state = dch->state;
--
2.7.0
next reply other threads:[~2019-01-30 10:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-30 10:19 YueHaibing [this message]
2019-01-30 18:10 ` [PATCH -next] mISDN: hfcsusb: Fix potential NULL pointer dereference David Miller
2019-01-31 9:41 ` YueHaibing
2019-01-31 17:25 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190130101902.19744-1-yuehaibing@huawei.com \
--to=yuehaibing@huawei.com \
--cc=bigeasy@linutronix.de \
--cc=davem@davemloft.net \
--cc=gustavo@embeddedor.com \
--cc=isdn@linux-pingi.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).