[v1,4/4] arm64: dts: qcom: msm8998: Add mmcc node
diff mbox series

Message ID 1548866184-30378-1-git-send-email-jhugo@codeaurora.org
State Superseded
Headers show
Series
  • MSM8998 Multimedia Clock Controller
Related show

Commit Message

Jeffrey Hugo Jan. 30, 2019, 4:36 p.m. UTC
Add MSM8998 Multimedia Clock Controller DT node.

Signed-off-by: Jeffrey Hugo <jhugo@codeaurora.org>
---
 arch/arm64/boot/dts/qcom/msm8998.dtsi | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

Comments

Stephen Boyd Feb. 5, 2019, 10:03 p.m. UTC | #1
Quoting Jeffrey Hugo (2019-01-30 08:36:24)
> diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qcom/msm8998.dtsi
> index 7136ab1..5673a65 100644
> --- a/arch/arm64/boot/dts/qcom/msm8998.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi
> @@ -814,6 +814,21 @@
>                         status = "disabled";
>                 };
>  
> +               mmcc: clock-controller@c8c0000 {
> +                       compatible = "qcom,mmcc-msm8998";
> +                       #clock-cells = <1>;
> +                       #reset-cells = <1>;
> +                       #power-domain-cells = <1>;
> +                       reg = <0x0c8c0000 0x40000>;
> +
> +                       clock-names =
> +                               "xo",

Weird newline here. Please put "xo" on the same line as clock-names.

> +                               "gpll0";
> +                       clocks =
> +                               <&rpmcc RPM_SMD_XO_CLK_SRC>,
> +                               <&gcc GPLL0_OUT_MAIN>;

Ah ok, so only the multimedia clks get the xo clk from rpm for now?
Jeffrey Hugo Feb. 5, 2019, 10:10 p.m. UTC | #2
On 2/5/2019 3:03 PM, Stephen Boyd wrote:
> Quoting Jeffrey Hugo (2019-01-30 08:36:24)
>> diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qcom/msm8998.dtsi
>> index 7136ab1..5673a65 100644
>> --- a/arch/arm64/boot/dts/qcom/msm8998.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi
>> @@ -814,6 +814,21 @@
>>                          status = "disabled";
>>                  };
>>   
>> +               mmcc: clock-controller@c8c0000 {
>> +                       compatible = "qcom,mmcc-msm8998";
>> +                       #clock-cells = <1>;
>> +                       #reset-cells = <1>;
>> +                       #power-domain-cells = <1>;
>> +                       reg = <0x0c8c0000 0x40000>;
>> +
>> +                       clock-names =
>> +                               "xo",
> 
> Weird newline here. Please put "xo" on the same line as clock-names.
> 
>> +                               "gpll0";
>> +                       clocks =
>> +                               <&rpmcc RPM_SMD_XO_CLK_SRC>,
>> +                               <&gcc GPLL0_OUT_MAIN>;
> 
> Ah ok, so only the multimedia clks get the xo clk from rpm for now?
> 

Yes.  With this entire series, its possible to retrofit GCC, but I 
didn't tackle that since we'd need to consider backwards compatibility. 
I hope to do this moving forward though.

Patch
diff mbox series

diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qcom/msm8998.dtsi
index 7136ab1..5673a65 100644
--- a/arch/arm64/boot/dts/qcom/msm8998.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi
@@ -814,6 +814,21 @@ 
 			status = "disabled";
 		};
 
+		mmcc: clock-controller@c8c0000 {
+			compatible = "qcom,mmcc-msm8998";
+			#clock-cells = <1>;
+			#reset-cells = <1>;
+			#power-domain-cells = <1>;
+			reg = <0x0c8c0000 0x40000>;
+
+			clock-names =
+				"xo",
+				"gpll0";
+			clocks =
+				<&rpmcc RPM_SMD_XO_CLK_SRC>,
+				<&gcc GPLL0_OUT_MAIN>;
+		};
+
 		timer@17920000 {
 			#address-cells = <1>;
 			#size-cells = <1>;