From: Anwar Payyoorayil <anwar@austin.rr.com>
To: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: [PATCH] 2.4.0-prerelease-ac4: i810_audio.c: Alternate VRA fix
Date: Sat, 03 Feb 2001 01:43:45 -0600 [thread overview]
Message-ID: <3A7BB6B1.ABF71834@austin.rr.com> (raw)
Alan -
Based on your suggestion, I looked again, and found that even though the kernel
sets VRA, the bit is lost when the driver unnecessarily resets the CODEC. The
patch below removes the unnecessary resetting of the CODEC. Nothing seems to be
lost by removing the resetting, and the driver in 2.2 series (where VRA works
fine) does not do this reset.
If we find that somebody needs this reset, we can move the VRA enabling code
after the codec reset code.
Anwar.
Patch against 2.4.0-prerelease-ac4
--- linux/drivers/sound/i810_audio.c.ac4 Sat Feb 3 01:26:31 2001
+++ linux/drivers/sound/i810_audio.c Sat Feb 3 01:26:54 2001
@@ -1898,11 +1898,6 @@
pci_dev->driver_data = card;
pci_dev->dma_mask = I810_DMA_MASK;
-// printk("resetting codec?\n");
- outl(0, card->iobase + GLOB_CNT);
- udelay(500);
-// printk("bringing it back?\n");
- outl(1<<1, card->iobase + GLOB_CNT);
return 0;
}
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
next reply other threads:[~2001-01-03 8:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-02-03 7:43 Anwar Payyoorayil [this message]
2001-01-03 14:16 ` [PATCH] 2.4.0-prerelease-ac4: i810_audio.c: Alternate VRA fix Alan Cox
2001-01-27 1:52 ` Linux 2.4 hangs on PowerBook 150(m68k) Rafael Diniz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3A7BB6B1.ABF71834@austin.rr.com \
--to=anwar@austin.rr.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).