crypto: ccree: add missing inline qualifier
diff mbox series

Message ID 20190211142758.16718-1-gilad@benyossef.com
State Accepted
Commit f1071c3e2473ae19a7f5d892a187c4cab1a61f2e
Headers show
Series
  • crypto: ccree: add missing inline qualifier
Related show

Commit Message

Gilad Ben-Yossef Feb. 11, 2019, 2:27 p.m. UTC
Commit 1358c13a48c4 ("crypto: ccree - fix resume race condition on init")
was missing a "inline" qualifier for stub function used when CONFIG_PM
is not set causing a build warning.

Fixes: 1358c13a48c4 ("crypto: ccree - fix resume race condition on init")
Cc: stable@kernel.org # v4.20
Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
---
 drivers/crypto/ccree/cc_pm.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Geert Uytterhoeven Feb. 18, 2019, 8:48 a.m. UTC | #1
On Mon, Feb 11, 2019 at 3:29 PM Gilad Ben-Yossef <gilad@benyossef.com> wrote:
> Commit 1358c13a48c4 ("crypto: ccree - fix resume race condition on init")
> was missing a "inline" qualifier for stub function used when CONFIG_PM
> is not set causing a build warning.
>
> Fixes: 1358c13a48c4 ("crypto: ccree - fix resume race condition on init")
> Cc: stable@kernel.org # v4.20

# v5.0

However, I believe the version comment is not necessary, as the same
version is indicated by the Fixes tag.

> Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>

Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>

Gr{oetje,eeting}s,

                        Geert
Gilad Ben-Yossef Feb. 18, 2019, 11:57 a.m. UTC | #2
Hi,

On Mon, Feb 18, 2019 at 10:48 AM Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
>
> On Mon, Feb 11, 2019 at 3:29 PM Gilad Ben-Yossef <gilad@benyossef.com> wrote:
> > Commit 1358c13a48c4 ("crypto: ccree - fix resume race condition on init")
> > was missing a "inline" qualifier for stub function used when CONFIG_PM
> > is not set causing a build warning.
> >
> > Fixes: 1358c13a48c4 ("crypto: ccree - fix resume race condition on init")
> > Cc: stable@kernel.org # v4.20
>
> # v5.0
>
> However, I believe the version comment is not necessary, as the same
> version is indicated by the Fixes tag.

I've marked it v4.20 since I've marked the patch that this fixes for
inclusion in 4.20.

Although the underlying bug was there all along, it was only revealed
by a change that
went into 4.20.
>
> > Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
>
> Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
>


Thanks!
Gilad
Herbert Xu Feb. 22, 2019, 11:54 a.m. UTC | #3
On Mon, Feb 11, 2019 at 04:27:58PM +0200, Gilad Ben-Yossef wrote:
> Commit 1358c13a48c4 ("crypto: ccree - fix resume race condition on init")
> was missing a "inline" qualifier for stub function used when CONFIG_PM
> is not set causing a build warning.
> 
> Fixes: 1358c13a48c4 ("crypto: ccree - fix resume race condition on init")
> Cc: stable@kernel.org # v4.20
> Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
> ---
>  drivers/crypto/ccree/cc_pm.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Patch applied.  Thanks.

Patch
diff mbox series

diff --git a/drivers/crypto/ccree/cc_pm.h b/drivers/crypto/ccree/cc_pm.h
index f62624357020..907a6db4d6c0 100644
--- a/drivers/crypto/ccree/cc_pm.h
+++ b/drivers/crypto/ccree/cc_pm.h
@@ -30,7 +30,7 @@  static inline int cc_pm_init(struct cc_drvdata *drvdata)
 	return 0;
 }
 
-static void cc_pm_go(struct cc_drvdata *drvdata) {}
+static inline void cc_pm_go(struct cc_drvdata *drvdata) {}
 
 static inline void cc_pm_fini(struct cc_drvdata *drvdata) {}