ARM: dts: omap3-gta04: declare backlight in lcd node
diff mbox series

Message ID 20190211162007.15626-1-andreas@kemnade.info
State Accepted
Commit 947b7802597106dcbef2ddca23d386f9339ba334
Headers show
Series
  • ARM: dts: omap3-gta04: declare backlight in lcd node
Related show

Commit Message

Andreas Kemnade Feb. 11, 2019, 4:20 p.m. UTC
The lcd display of the gta04 has a backlight but the backlight
was not referenced in the lcd node, so screen blanking did
not turn off the backlight. Fix that.

Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
---
the backlight property for the driver was accepted here:
https://lore.kernel.org/lkml/a54e7427-ff84-d105-aab7-c5eab42e6df9@ti.com/

 arch/arm/boot/dts/omap3-gta04.dtsi | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

H. Nikolaus Schaller Feb. 11, 2019, 6:14 p.m. UTC | #1
> Am 11.02.2019 um 17:20 schrieb Andreas Kemnade <andreas@kemnade.info>:
> 
> The lcd display of the gta04 has a backlight but the backlight
> was not referenced in the lcd node, so screen blanking did
> not turn off the backlight. Fix that.
> 
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>

Works fine.

Tested-by: H. Nikolaus Schaller <hns@goldelico.com>

> ---
> the backlight property for the driver was accepted here:
> https://lore.kernel.org/lkml/a54e7427-ff84-d105-aab7-c5eab42e6df9@ti.com/
> 
> arch/arm/boot/dts/omap3-gta04.dtsi | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/omap3-gta04.dtsi b/arch/arm/boot/dts/omap3-gta04.dtsi
> index 8c55d33ff694..3b88eb5f1a72 100644
> --- a/arch/arm/boot/dts/omap3-gta04.dtsi
> +++ b/arch/arm/boot/dts/omap3-gta04.dtsi
> @@ -142,6 +142,7 @@
> 			spi-cpol;
> 			spi-cpha;
> 
> +			backlight= <&backlight>;
> 			label = "lcd";
> 			port {
> 				lcd_in: endpoint {
> @@ -151,7 +152,7 @@
> 		};
> 	};
> 
> -	backlight {
> +	backlight: backlight {
> 		compatible = "pwm-backlight";
> 		pwms = <&pwm11 0 12000000 0>;
> 		pwm-names = "backlight";
> -- 
> 2.11.0
> 
> _______________________________________________
> http://projects.goldelico.com/p/gta04-kernel/
> Letux-kernel mailing list
> Letux-kernel@openphoenux.org
> http://lists.goldelico.com/mailman/listinfo.cgi/letux-kernel
Tony Lindgren Feb. 13, 2019, 3:49 p.m. UTC | #2
* H. Nikolaus Schaller <hns@goldelico.com> [190211 18:14]:
> 
> > Am 11.02.2019 um 17:20 schrieb Andreas Kemnade <andreas@kemnade.info>:
> > 
> > The lcd display of the gta04 has a backlight but the backlight
> > was not referenced in the lcd node, so screen blanking did
> > not turn off the backlight. Fix that.
> > 
> > Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> 
> Works fine.
> 
> Tested-by: H. Nikolaus Schaller <hns@goldelico.com>

Thanks applied into omap-for-v5.1/dt.

Tony

Patch
diff mbox series

diff --git a/arch/arm/boot/dts/omap3-gta04.dtsi b/arch/arm/boot/dts/omap3-gta04.dtsi
index 8c55d33ff694..3b88eb5f1a72 100644
--- a/arch/arm/boot/dts/omap3-gta04.dtsi
+++ b/arch/arm/boot/dts/omap3-gta04.dtsi
@@ -142,6 +142,7 @@ 
 			spi-cpol;
 			spi-cpha;
 
+			backlight= <&backlight>;
 			label = "lcd";
 			port {
 				lcd_in: endpoint {
@@ -151,7 +152,7 @@ 
 		};
 	};
 
-	backlight {
+	backlight: backlight {
 		compatible = "pwm-backlight";
 		pwms = <&pwm11 0 12000000 0>;
 		pwm-names = "backlight";