iscsi_ibft: Fix missing break in switch statement
diff mbox series

Message ID 20190211184323.GA3671@embeddedor
State New
Headers show
Series
  • iscsi_ibft: Fix missing break in switch statement
Related show

Commit Message

Gustavo A. R. Silva Feb. 11, 2019, 6:43 p.m. UTC
Add missing break statement in order to prevent the code from falling
through to case ISCSI_BOOT_TGT_NAME, which is unnecessary.

This bug was found thanks to the ongoing efforts to enable
-Wimplicit-fallthrough.

Fixes: b33a84a38477 ("ibft: convert iscsi_ibft module to iscsi boot lib")
Cc: stable@vger.kernel.org
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
 drivers/firmware/iscsi_ibft.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Konrad Rzeszutek Wilk Feb. 12, 2019, 6:46 p.m. UTC | #1
On Mon, Feb 11, 2019 at 12:43:23PM -0600, Gustavo A. R. Silva wrote:
> Add missing break statement in order to prevent the code from falling
> through to case ISCSI_BOOT_TGT_NAME, which is unnecessary.
> 
> This bug was found thanks to the ongoing efforts to enable
> -Wimplicit-fallthrough.
> 
> Fixes: b33a84a38477 ("ibft: convert iscsi_ibft module to iscsi boot lib")
> Cc: stable@vger.kernel.org
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>


Queued it up in https://git.kernel.org/pub/scm/linux/kernel/git/konrad/ibft.git
> ---
>  drivers/firmware/iscsi_ibft.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/firmware/iscsi_ibft.c b/drivers/firmware/iscsi_ibft.c
> index 6bc8e6640d71..c51462f5aa1e 100644
> --- a/drivers/firmware/iscsi_ibft.c
> +++ b/drivers/firmware/iscsi_ibft.c
> @@ -542,6 +542,7 @@ static umode_t __init ibft_check_tgt_for(void *data, int type)
>  	case ISCSI_BOOT_TGT_NIC_ASSOC:
>  	case ISCSI_BOOT_TGT_CHAP_TYPE:
>  		rc = S_IRUGO;
> +		break;
>  	case ISCSI_BOOT_TGT_NAME:
>  		if (tgt->tgt_name_len)
>  			rc = S_IRUGO;
> -- 
> 2.20.1
>
Gustavo A. R. Silva Feb. 12, 2019, 6:49 p.m. UTC | #2
On 2/12/19 12:46 PM, Konrad Rzeszutek Wilk wrote:
> On Mon, Feb 11, 2019 at 12:43:23PM -0600, Gustavo A. R. Silva wrote:
>> Add missing break statement in order to prevent the code from falling
>> through to case ISCSI_BOOT_TGT_NAME, which is unnecessary.
>>
>> This bug was found thanks to the ongoing efforts to enable
>> -Wimplicit-fallthrough.
>>
>> Fixes: b33a84a38477 ("ibft: convert iscsi_ibft module to iscsi boot lib")
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> 
> 
> Queued it up in https://git.kernel.org/pub/scm/linux/kernel/git/konrad/ibft.git

Great.

Thanks, Konrad.
--
Gustavo

Patch
diff mbox series

diff --git a/drivers/firmware/iscsi_ibft.c b/drivers/firmware/iscsi_ibft.c
index 6bc8e6640d71..c51462f5aa1e 100644
--- a/drivers/firmware/iscsi_ibft.c
+++ b/drivers/firmware/iscsi_ibft.c
@@ -542,6 +542,7 @@  static umode_t __init ibft_check_tgt_for(void *data, int type)
 	case ISCSI_BOOT_TGT_NIC_ASSOC:
 	case ISCSI_BOOT_TGT_CHAP_TYPE:
 		rc = S_IRUGO;
+		break;
 	case ISCSI_BOOT_TGT_NAME:
 		if (tgt->tgt_name_len)
 			rc = S_IRUGO;