From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: linux-kbuild@vger.kernel.org
Cc: Sam Ravnborg <sam@ravnborg.org>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Michal Marek <michal.lkml@markovi.net>,
linux-kernel@vger.kernel.org
Subject: [PATCH 3/8] kbuild: set KBUILD_MODULES=1 all the time for single target %/
Date: Thu, 14 Feb 2019 12:05:16 +0900 [thread overview]
Message-ID: <1550113521-23577-3-git-send-email-yamada.masahiro@socionext.com> (raw)
In-Reply-To: <1550113521-23577-1-git-send-email-yamada.masahiro@socionext.com>
It is fine to set KBUILD_MODULES=1 when CONFIG_MODULES is disabled.
It is actually how "make allnoconfig all" works.
On the other hand, KBUILD_MODULES=1 is unneeded for the %.ko pattern.
It is just a matter of whether modules.order is generated or not.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
Makefile | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/Makefile b/Makefile
index 3cf253d..fe62de3 100644
--- a/Makefile
+++ b/Makefile
@@ -1710,16 +1710,13 @@ endif
# Modules
/: prepare FORCE
- $(Q)$(MAKE) KBUILD_MODULES=$(if $(CONFIG_MODULES),1) \
- $(build)=$(build-dir)
+ $(Q)$(MAKE) KBUILD_MODULES=1 $(build)=$(build-dir)
# Make sure the latest headers are built for Documentation
Documentation/ samples/: headers_install
%/: prepare FORCE
- $(Q)$(MAKE) KBUILD_MODULES=$(if $(CONFIG_MODULES),1) \
- $(build)=$(build-dir)
+ $(Q)$(MAKE) KBUILD_MODULES=1 $(build)=$(build-dir)
%.ko: prepare FORCE
- $(Q)$(MAKE) KBUILD_MODULES=$(if $(CONFIG_MODULES),1) \
- $(build)=$(build-dir) $(@:.ko=.o)
+ $(Q)$(MAKE) $(build)=$(build-dir) $(@:.ko=.o)
$(Q)$(MAKE) -f $(srctree)/scripts/Makefile.modpost
# FIXME Should go into a make.lib or something
--
2.7.4
next prev parent reply other threads:[~2019-02-14 3:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-14 3:05 [PATCH 1/8] kbuild: pkg: use -f $(srctree)/Makefile to recurse to top Makefile Masahiro Yamada
2019-02-14 3:05 ` [PATCH 2/8] kbuild: generate modules.order only when CONFIG_MODULES=y Masahiro Yamada
2019-02-14 3:05 ` Masahiro Yamada [this message]
2019-02-14 3:05 ` [PATCH 4/8] kbuild: turn '/' into an alias of './' Masahiro Yamada
2019-02-14 3:05 ` [PATCH 5/8] kbuild: move tools_silent to a more relevant place Masahiro Yamada
2019-02-14 3:05 ` [PATCH 6/8] kbuild: make -r/-R effective in top Makefile for old Make versions Masahiro Yamada
2019-02-14 3:05 ` [PATCH 7/8] kbuild: remove empty rules for makefiles Masahiro Yamada
2019-02-14 3:05 ` [PATCH 8/8] kbuild: simplify single targets Masahiro Yamada
2019-02-20 3:43 ` [PATCH 1/8] kbuild: pkg: use -f $(srctree)/Makefile to recurse to top Makefile Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1550113521-23577-3-git-send-email-yamada.masahiro@socionext.com \
--to=yamada.masahiro@socionext.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).