From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: linuxppc-dev@lists.ozlabs.org, Michael Ellerman <mpe@ellerman.id.au>
Cc: Masahiro Yamada <yamada.masahiro@socionext.com>,
Paul Mackerras <paulus@samba.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
linux-kernel@vger.kernel.org
Subject: [PATCH] powerpc: use $(origin ARCH) to select KBUILD_DEFCONFIG
Date: Fri, 15 Feb 2019 18:38:39 +0900 [thread overview]
Message-ID: <1550223519-18290-1-git-send-email-yamada.masahiro@socionext.com> (raw)
I often test all Kconfig commands for all architectures. To ease my
workflow, I want 'make defconfig' at least working without any cross
compiler.
Currently, arch/powerpc/Makefile checks CROSS_COMPILE to decide the
default defconfig source.
If CROSS_COMPILE is unset, it is likely to be the native build, so
'uname -m' is useful to choose the defconfig. If CROSS_COMPILE is set,
the user is cross-building (i.e. 'uname -m' is probably x86_64), so
it falls back to ppc64_defconfig. Yup, make sense.
However, I want to run 'make ARCH=* defconfig' without setting
CROSS_COMPILE for each architecture.
My suggestion is to check $(origin ARCH).
When you cross-compile the kernel, you need to set ARCH from your
environment or from the command line.
For the native build, you do not need to set ARCH. The default in
the top Makefile is used:
ARCH ?= $(SUBARCH)
Hence, $(origin ARCH) returns 'file'.
Before this commit, 'make ARCH=powerpc defconfig' failed:
$ make ARCH=powerpc defconfig
*** Default configuration is based on target 'x86_64_defconfig'
***
*** Can't find default configuration "arch/powerpc/configs/x86_64_defconfig"!
***
After this commit, it will succeed:
$ make ARCH=powerpc defconfig
*** Default configuration is based on 'ppc64_defconfig'
#
# configuration written to .config
#
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
arch/powerpc/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/Makefile b/arch/powerpc/Makefile
index ac03334..f989979 100644
--- a/arch/powerpc/Makefile
+++ b/arch/powerpc/Makefile
@@ -34,7 +34,7 @@ ifdef CONFIG_PPC_BOOK3S_32
KBUILD_CFLAGS += -mcpu=powerpc
endif
-ifeq ($(CROSS_COMPILE),)
+ifeq ($(origin ARCH), file)
KBUILD_DEFCONFIG := $(shell uname -m)_defconfig
else
KBUILD_DEFCONFIG := ppc64_defconfig
--
2.7.4
next reply other threads:[~2019-02-15 9:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-15 9:38 Masahiro Yamada [this message]
2019-02-15 11:00 ` [PATCH] powerpc: use $(origin ARCH) to select KBUILD_DEFCONFIG Mathieu Malaterre
2019-02-16 2:25 ` Masahiro Yamada
2019-03-13 20:17 ` Mathieu Malaterre
2019-03-14 2:24 ` Michael Ellerman
2019-03-15 15:25 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1550223519-18290-1-git-send-email-yamada.masahiro@socionext.com \
--to=yamada.masahiro@socionext.com \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).