From: Wei Yongjun <weiyongjun1@huawei.com>
To: Benson Leung <bleung@chromium.org>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Duncan Laurie <dlaurie@google.com>,
"Nick Crews" <ncrews@chromium.org>
Cc: Wei Yongjun <weiyongjun1@huawei.com>,
<linux-kernel@vger.kernel.org>, <kernel-janitors@vger.kernel.org>
Subject: [PATCH -next] platform/chrome: Make function wilco_ec_transfer() static
Date: Sat, 16 Feb 2019 06:09:10 +0000 [thread overview]
Message-ID: <20190216060910.139768-1-weiyongjun1@huawei.com> (raw)
Fixes the following sparse warning:
drivers/platform/chrome/wilco_ec/mailbox.c:126:5: warning:
symbol 'wilco_ec_transfer' was not declared. Should it be static?
Fixes: 436dad4fda10 ("platform/chrome: Add new driver for Wilco EC")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/platform/chrome/wilco_ec/mailbox.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/platform/chrome/wilco_ec/mailbox.c b/drivers/platform/chrome/wilco_ec/mailbox.c
index c7028488e575..f6ff29a11f1a 100644
--- a/drivers/platform/chrome/wilco_ec/mailbox.c
+++ b/drivers/platform/chrome/wilco_ec/mailbox.c
@@ -123,8 +123,9 @@ static void wilco_ec_prepare(struct wilco_ec_message *msg,
* Context: ec->mailbox_lock should be held while using this function.
* Return: number of bytes received or negative error code on failure.
*/
-int wilco_ec_transfer(struct wilco_ec_device *ec, struct wilco_ec_message *msg,
- struct wilco_ec_request *rq)
+static int wilco_ec_transfer(struct wilco_ec_device *ec,
+ struct wilco_ec_message *msg,
+ struct wilco_ec_request *rq)
{
struct wilco_ec_response *rs;
u8 checksum;
next reply other threads:[~2019-02-16 6:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-16 6:09 Wei Yongjun [this message]
2019-02-18 10:14 ` [PATCH -next] platform/chrome: Make function wilco_ec_transfer() static Enric Balletbo i Serra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190216060910.139768-1-weiyongjun1@huawei.com \
--to=weiyongjun1@huawei.com \
--cc=bleung@chromium.org \
--cc=dlaurie@google.com \
--cc=enric.balletbo@collabora.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ncrews@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).