From: Dan Williams <dan.j.williams@intel.com>
To: akpm@linux-foundation.org
Cc: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
Vlastimil Babka <vbabka@suse.cz>, Michal Hocko <mhocko@suse.com>,
Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: [PATCH] mm: Fix buddy list helpers
Date: Sat, 16 Feb 2019 09:07:02 -0800 [thread overview]
Message-ID: <155033679702.1773410.13041474192173212653.stgit@dwillia2-desk3.amr.corp.intel.com> (raw)
Tetsuo reports that free page statistics are not reporting correctly,
and Vlastimil noticed that "mm: Move buddy list manipulations into
helpers" botched one of its conversions of add_to_free_area(). Fix the
double-increment of ->nr_free.
Reported-by: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Reported-by: Vlastimil Babka <vbabka@suse.cz>
Cc: Michal Hocko <mhocko@suse.com>
Tested-by: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
---
Hi Andrew,
Please fold this into
mm-move-buddy-list-manipulations-into-helpers.patch.
mm/page_alloc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 2a0969e3b0eb..da537fc39c54 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -1851,7 +1851,6 @@ static inline void expand(struct zone *zone, struct page *page,
continue;
add_to_free_area(&page[size], area, migratetype);
- area->nr_free++;
set_page_order(&page[size], high);
}
}
next reply other threads:[~2019-02-16 17:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-16 17:07 Dan Williams [this message]
2019-02-18 9:42 ` [PATCH] mm: Fix buddy list helpers Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=155033679702.1773410.13041474192173212653.stgit@dwillia2-desk3.amr.corp.intel.com \
--to=dan.j.williams@intel.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).